gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 8338: (QA follow-up) Fix test for backdated return 

A test for CalculateFinesOnBackdate was introduced since this bug was
written and needed updateing.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2020-07-21 11:18:16 +01:00 committed by Jonathan Druart
parent 4f5f5d88b9
commit 56ee42082f
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
t/db_dependent/Circulation/Returns.t
View File

@ -400,7 +400,7 @@ subtest 'BranchTransferLimitsType' => sub {
};
subtest 'Backdated returns should reduce fine if needed' => sub {
plan tests => 1;
plan tests => 3;
t::lib::Mocks::mock_preference( "CalculateFinesOnReturn", 0 );
t::lib::Mocks::mock_preference( "CalculateFinesOnBackdate", 1 );
@ -434,10 +434,14 @@ subtest 'Backdated returns should reduce fine if needed' => sub {
branchcode => $patron->branchcode,
})->store();
my ( $doreturn, $messages, $issue ) = AddReturn($item->barcode, undef, undef, dt_from_string('1999-01-01') );
my $account = $patron->account;
is( $account->balance+0, 100, "Account balance before return is 100");
$fine->discard_changes;
is( $fine->amountoutstanding+0, 0, "Fine was reduced correctly with a backdated return" );
my ( $doreturn, $messages, $issue ) = AddReturn($item->barcode, undef, undef, dt_from_string('1999-01-01') );
is( $account->balance+0, 0, "Account balance after return is 0");
$fine = $fine->get_from_storage;
is( $fine, undef, "Fine was removed correctly with a backdated return" );
};
$schema->storage->txn_rollback;