gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41879: Disallow moves to invalid pickup locations for items 

To test:

1. Set ReservesControlBranch is set to 'item's home library'
2. Set the deafult 'Holds and bookings policies by item type' for the itype BK to allow holds from patrons from any library, but pickup at CPL only
3. Have a bib owned by another library ( I used MPL ), and bib owned by CPL. Both are the item type BK, and each has one item on the bib.
4. Place a hold for a patron on bib A for pickup at MPL
5. Move the hold to bib B
6. Note that the hold moves successfully, and is still set for pickup at MPL
7. Login and try to trigger the hold, nothing happens
8. APPLY PATCH, restart_all
9. Try spets 3 - 6 again. This time on step 6 you should see a message that the hold cannot be moved.

Signed-off-by: Eric Phetteplace <phette23@gmail.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Lucas Gass 2026-05-07 16:03:03 +00:00 committed by Pedro Amorim
parent 4c3e4b8bd7
commit 560efd018b
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Koha/Hold.pm
View File

@ -214,6 +214,16 @@ sub move_hold {
$new_itemnumber = $item->itemnumber;
$new_biblionumber = $item->biblionumber;
my $branchitemrule = C4::Circulation::GetBranchItemRule(
Koha::Policy::Holds->holds_control_library( $item, $patron ),
$item->effective_itemtype
);
my $policy = $branchitemrule->{hold_fulfillment_policy};
if ( ( $policy eq 'homebranch' || $policy eq 'holdingbranch' ) && $self->branchcode ne $item->$policy ) {
return { success => 0, error => 'invalidPickupBranch' };
}
$canReserve = C4::Reserves::CanItemBeReserved( $patron, $item, $self->branchcode, { ignore_hold_counts => 1 } );
} elsif ( $args->{new_biblionumber} ) {
$new_biblionumber = $args->{new_biblionumber};
@ -222,6 +232,9 @@ sub move_hold {
$patron->borrowernumber, $new_biblionumber, $self->branchcode,
{ ignore_hold_counts => 1 }
);
# for record level holds we must check to make sure there is an item on the record that can fufill the new hold
} else {
return { success => 0, error => 'Missing itemnumber or biblionumber' };
}

2
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View File

@ -225,6 +225,8 @@
<span>Target item is not for loan</span>
[% CASE 'damaged' %]
<span>Target item is damaged</span>
[% CASE 'invalidPickupBranch' %]
<span>Target item is an invalid pickup location</span>
[% CASE %]
<span>Error: [% fail.error | html %]</span>
[% END %]