gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 34014: Unit test 

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2023-10-17 18:06:27 +00:00 committed by Tomas Cohen Arazi
parent 8dc2152e2f
commit 5506a031ed
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
1 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
t/db_dependent/Biblio.t
View File

@ -17,7 +17,7 @@
use Modern::Perl;
use Test::More tests => 19;
use Test::More tests => 20;
use Test::MockModule;
use Test::Warn;
use List::MoreUtils qw( uniq );
@ -26,6 +26,7 @@ use MARC::Record;
use t::lib::Mocks qw( mock_preference );
use t::lib::TestBuilder;
use Koha::ActionLogs;
use Koha::Database;
use Koha::Caches;
use Koha::MarcSubfieldStructures;
@ -996,6 +997,31 @@ subtest 'GetFrameworkCode' => sub {
};
subtest 'ModBiblio on invalid record' => sub {
plan tests => 3;
t::lib::Mocks::mock_preference( "CataloguingLog", 1 );
# We create a record with an onvalid control character in the MARC
my $record = MARC::Record->new();
my $field = MARC::Field->new( '650', '', '', 'a' => '00aD000015937' );
$record->append_fields($field);
my ($biblionumber) = C4::Biblio::AddBiblio( $record, '' );
warning_like { C4::Biblio::ModBiblio( $record, $biblionumber, '' ); }
qr/parser error : PCDATA invalid Char value 31/,
'Modding the biblio warns about the encoding issues';
my $action_logs =
Koha::ActionLogs->search( { object => $biblionumber, module => 'Cataloguing', action => 'MODIFY' } );
is( $action_logs->count, 1, "Modification of biblio was successful and recorded" );
my $action_log = $action_logs->next;
like(
$action_log->info, qr/parser error : PCDATA invalid Char value 31/,
"Metadata issue successfully logged in action logs"
);
};
# Cleanup
Koha::Caches->get_instance->clear_from_cache( "MarcSubfieldStructure-" );
$schema->storage->txn_rollback;