From 5044480276cb4bf99f5a9eda280705ffe57e3ef9 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date: Tue, 24 Jun 2025 17:19:18 +0100
Subject: [PATCH] Bug 40022: Add missing roles to the include

This patch adds missing role mappings to the about-team.inc template
to ensure all roles defined in teams.yaml are properly displayed.

Added role mappings include:
- manager_assistants (plural form)
- maintainer_assistants (plural form)
- maintainer_mentors (plural form)
- accessibility_advocates (plural form)
- security_manager
- meeting_facilitator
- social_media
- website

Also adds display logic for historical roles that may not be present
in current teams but appear in contributor lists from teams.yaml.

This ensures complete coverage of all team roles across historical
and current release teams.

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 1159aecb11cbba14b2b43ee57da1bcabc968e68a)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
---
 .../prog/en/includes/about-team.inc           | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc
index 8c01e49331..e9a708e3d2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc
@@ -8,6 +8,8 @@
         <span>Release manager</span>
     [%- CASE 'manager_assistant' -%]
         <span>Release manager assistant</span>
+    [%- CASE 'manager_assistants' -%]
+        <span>Release manager assistants</span>
     [%- CASE 'manager_mentor' -%]
         <span>Release manager mentor</span>
     [%- CASE 'qa_manager' -%]
@@ -32,8 +34,12 @@
         <span>Release maintainer</span>
     [%- CASE 'maintainer_assistant' -%]
         <span>Release maintainer assistant</span>
+    [%- CASE 'maintainer_assistants' -%]
+        <span>Release maintainer assistants</span>
     [%- CASE 'maintainer_mentor' -%]
         <span>Release maintainer mentor</span>
+    [%- CASE 'maintainer_mentors' -%]
+        <span>Release maintainer mentors</span>
     [%- CASE 'wiki' -%]
         <span>Wiki curator</span>
     [%- CASE 'ci' -%]
@@ -56,6 +62,8 @@
         <span>Live CD maintainer</span>
     [%- CASE 'accessibility_advocate' -%]
         <span>Accessibility advocate</span>
+    [%- CASE 'accessibility_advocates' -%]
+        <span>Accessibility advocates</span>
     [%- CASE 'meeting_facilitator' -%]
         <span>Meeting facilitator</span>
     [%- CASE 'ktd' -%]
@@ -356,6 +364,48 @@
             [% END %]
         [% END %]
 
+        [% IF t.meeting_facilitator %]
+            <li
+                ><strong>Meeting facilitator:</strong>
+                [% INCLUDE person p=t.meeting_facilitator %]
+            </li>
+        [% END %]
+
+        [% IF t.chairperson %]
+            <li
+                ><strong>Meetings chairperson:</strong>
+                [% INCLUDE person p=t.chairperson %]
+            </li>
+        [% END %]
+
+        [% IF t.database %]
+            <li
+                ><strong>Documentation specialist:</strong>
+                [% INCLUDE person p=t.database %]
+            </li>
+        [% END %]
+
+        [% IF t.live_cd %]
+            <li
+                ><strong>Live CD maintainer:</strong>
+                [% INCLUDE person p=t.live_cd %]
+            </li>
+        [% END %]
+
+        [% IF t.vm %]
+            <li
+                ><strong>Virtual machine maintainer:</strong>
+                [% INCLUDE person p=t.vm %]
+            </li>
+        [% END %]
+
+        [% IF t.translation_assistant %]
+            <li
+                ><strong>Translation manager assistant:</strong>
+                [% INCLUDE person p=t.translation_assistant %]
+            </li>
+        [% END %]
+
         [% IF v != 'release' %]
             <li
                 ><strong>Release manager:</strong>