From 4ff58e553b33a495d5d0564ab5db63f7dbbdcf8d Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Tue, 15 Sep 2026 11:16:46 +0100 Subject: [PATCH] Bug 31391: (QA follow-up) Remove unused variables in ModReserve recall conversion $due_interval and $due_date (and $recall itself) returned by Koha::Recalls->add_recall were captured but never used in either branch of the new rank => "recall" handling. Drop the unused assignment - no behaviour change. Test plan: 1) prove t/db_dependent/Holds.t t/db_dependent/Reserves.t - all pass Signed-off-by: Pedro Amorim --- C4/Reserves.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 4cf8eb5652..94a1fa3441 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -1253,7 +1253,7 @@ sub ModReserve { my $patron = Koha::Patrons->find($borrowernumber); if ( $hold->item_level_hold ) { if ( $hold->item->can_be_recalled( { patron => $patron, hold_convert => 1 } ) ) { - my ( $recall, $due_interval, $due_date ) = Koha::Recalls->add_recall( + Koha::Recalls->add_recall( { patron => $patron, biblio => $biblio, @@ -1267,7 +1267,7 @@ sub ModReserve { } } else { if ( $biblio->can_be_recalled( { patron => $patron, hold_convert => 1 } ) ) { - my ( $recall, $due_interval, $due_date ) = Koha::Recalls->add_recall( + Koha::Recalls->add_recall( { patron => $patron, biblio => $biblio,