Bug 35808: Remove obsolete responsive table markup from several pages in the OPAC
This patch removes span.tdlabel from several templates. The markup is
obsolete now that we use the DataTables responsive feature.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)
- Log in to the OPAC as a user with checkouts, suggestions, and tags.
- Check these pages to confirm that the tables on each one have the
correct responsive behavior at varying browser widths:
- OPAC home -> Most popular
- Your account
- Your account -> Checkout history
- Your account -> Suggestions
- Your account -> Tags
* The recalls history page is fixed in Bug 37158
Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 2627cfbe1d)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Owen Leonard
Paul Derscheid
parent
3565e9c59a
commit
4fa4464601
|
|
@ -99,10 +99,6 @@
|
|||
margin-bottom: .5em;
|
||||
}
|
||||
|
||||
.table:not( .collapsed ) .tdlabel {
|
||||
display: inline;
|
||||
}
|
||||
|
||||
.table td.bibliocol {
|
||||
padding-left: 1.3em;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -2170,11 +2170,6 @@ nav {
|
|||
z-index: 5;
|
||||
}
|
||||
|
||||
.tdlabel {
|
||||
display: none;
|
||||
font-weight: bold;
|
||||
}
|
||||
|
||||
#ulactioncontainer {
|
||||
min-width: 16em;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -190,12 +190,10 @@
|
|||
[% END %]
|
||||
[% END %]
|
||||
<span class="itypetext">
|
||||
<span class="tdlabel">Item type:</span>
|
||||
[% item_type.translated_description | html %]
|
||||
</span>
|
||||
</td>
|
||||
<td>
|
||||
<span class="tdlabel">Call number:</span>
|
||||
[% item.itemcallnumber | html %]
|
||||
</td>
|
||||
<td>
|
||||
|
|
@ -205,7 +203,6 @@
|
|||
</td>
|
||||
[% IF checkout.returndate %]
|
||||
<td data-order="[% checkout.returndate | html %]">
|
||||
<span class="tdlabel">Check-in date:</span>
|
||||
[% checkout.returndate | $KohaDates %]
|
||||
</td>
|
||||
[% ELSE %]
|
||||
|
|
|
|||
|
|
@ -449,14 +449,12 @@
|
|||
</td>
|
||||
<td>
|
||||
[% IF ( suggestion.note ) %]
|
||||
<span class="tdlabel">Note: </span>
|
||||
[% suggestion.note | html %]
|
||||
[% END %]
|
||||
</td>
|
||||
[% IF Koha.Preference( 'OPACViewOthersSuggestions' ) == 1 %]
|
||||
<td>
|
||||
[% IF suggestion.suggestedby %]
|
||||
<span class="tdlabel">Suggested for:</span>
|
||||
[% Branches.GetName(suggestion.branchcode) | html %]
|
||||
[% END %]
|
||||
</td>
|
||||
|
|
@ -464,14 +462,12 @@
|
|||
[% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %]
|
||||
<td>
|
||||
[% IF suggestion.managedby %]
|
||||
<span class="tdlabel">Managed by:</span>
|
||||
[% INCLUDE 'patron-title.inc' patron = suggestion.manager %]
|
||||
[% IF ( suggestion.manageddate ) %] - [% suggestion.manageddate | $KohaDates %][% END %]
|
||||
[% END %]
|
||||
</td>
|
||||
[% END %]
|
||||
<td>
|
||||
<span class="tdlabel">Status:</span>
|
||||
[% IF ( suggestion.STATUS == 'ASKED' ) %]<span>Requested</span>
|
||||
[% ELSIF ( suggestion.STATUS == 'CHECKED' ) %]<span>Checked by the library</span>
|
||||
[% ELSIF ( suggestion.STATUS == 'ACCEPTED' ) %]<span>Accepted by the library</span>
|
||||
|
|
|
|||
|
|
@ -163,7 +163,6 @@
|
|||
<input type="checkbox" class="cb" name="biblionumber" value="[% MY_TAG.biblionumber | html %]" data-title="[% MY_TAG.title | html %]" data-tagname="[% MY_TAG.term | html %]" data-tagid="[% MY_TAG.tag_id | html %]" aria-label="[% check_title | html %]"/>
|
||||
</td>
|
||||
<td class="tagterm">
|
||||
<span class="tdlabel">Tag:</span>
|
||||
[% IF MY_TAG.approved == 1 %]
|
||||
<a href="/cgi-bin/koha/opac-search.pl?tag=[% MY_TAG.term |uri %]&q=[% MY_TAG.term |uri %]">[% MY_TAG.term | html %]</a>
|
||||
[% ELSE %]
|
||||
|
|
@ -174,7 +173,6 @@
|
|||
[% IF ( MY_TAG.XSLTBloc ) %]
|
||||
[% MY_TAG.XSLTBloc | $raw %]
|
||||
[% ELSE %]
|
||||
<span class="tdlabel">Title:</span>
|
||||
[% INCLUDE 'biblio-title.inc' biblio=MY_TAG link=> 1 %]
|
||||
[% IF ( MY_TAG.author ) %]
|
||||
by [% MY_TAG.author | html %]
|
||||
|
|
@ -184,7 +182,6 @@
|
|||
[% INCLUDE 'title-actions-menu.inc' items=MY_TAG %]
|
||||
</td>
|
||||
<td data-order="[% MY_TAG.date_created | html %]">
|
||||
<span class="tdlabel">Date added:</span>
|
||||
[% MY_TAG.date_created | $KohaDates %]
|
||||
</td>
|
||||
<td>
|
||||
|
|
|
|||
|
|
@ -109,15 +109,12 @@
|
|||
[% IF ( result.item('size') ) %][% result.item('size') | html %][% END %]</p>
|
||||
</td>
|
||||
<td>
|
||||
<span class="tdlabel">Item type</span>
|
||||
[% ItemTypes.GetDescription(result.itemtype) | html %]
|
||||
</td>
|
||||
<td>
|
||||
<span class="tdlabel">Collection</span>
|
||||
[% AuthorisedValues.GetByCode('ccode', result.ccode, 1) | html %]
|
||||
</td>
|
||||
<td data-order="[% result.count | html %]">
|
||||
<span class="tdlabel">Checkouts: </span>
|
||||
[% result.count | html %]
|
||||
</td>
|
||||
[% IF Koha.Preference( 'opacuserlogin' ) == 1 %]
|
||||
|
|
|
|||
|
|
@ -418,18 +418,15 @@
|
|||
<td class="author">[% ISSUE.author | html %]</td>
|
||||
[% IF ( ISSUE.overdue ) %]
|
||||
<td class="date_due overdue" data-order="[% ISSUE.date_due | html %]">
|
||||
<span class="tdlabel">Date due:</span>
|
||||
[% ISSUE.date_due | $KohaDates as_due_date => 1 %]
|
||||
</td>
|
||||
[% ELSE %]
|
||||
<td class="date_due" data-order="[% ISSUE.date_due | html %]">
|
||||
<span class="tdlabel">Date due:</span>
|
||||
[% ISSUE.date_due | $KohaDates as_due_date => 1 %]
|
||||
</td>
|
||||
[% END %]
|
||||
[% IF ( Koha.Preference('BiblioItemtypeInfo') || !item_level_itypes ) %]
|
||||
<td class="itype">
|
||||
<span class="tdlabel">Item type:</span>
|
||||
[% IF ( ISSUE.imageurl && !Koha.Preference('OpacNoItemTypeImages') ) %]
|
||||
<img class="itemtype-image" src="[% ISSUE.imageurl | html %]" title="[% ISSUE.description | html %]" alt="[% ISSUE.description | html %]" />
|
||||
[% END %] <span class="itypetext">[% ISSUE.description | html %]</span>
|
||||
|
|
@ -437,12 +434,10 @@
|
|||
[% END %]
|
||||
[% IF ( show_barcode ) %]
|
||||
<td class="barcode">
|
||||
<span class="tdlabel">Barcode:</span>
|
||||
[% ISSUE.barcode | html %]
|
||||
</td>
|
||||
[% END %]
|
||||
<td class="call_no">
|
||||
<span class="tdlabel">Call number:</span>
|
||||
[% ISSUE.itemcallnumber | html %]
|
||||
</td>
|
||||
[% IF ( OpacRenewalAllowed && !( logged_in_user.is_expired && logged_in_user.category.effective_BlockExpiredPatronOpacActions_contains('renew') ) ) %]
|
||||
|
|
@ -515,7 +510,6 @@
|
|||
[% END %]
|
||||
[% IF ( OPACFinesTab ) %]
|
||||
<td class="fines">
|
||||
<span class="tdlabel">Fines:</span>
|
||||
[% IF ( ISSUE.charges ) %]
|
||||
<span>Yes (Item overdue or lost)</span>
|
||||
[% ELSIF ( ISSUE.rentalfines ) %]
|
||||
|
|
@ -785,16 +779,13 @@
|
|||
[% END %]
|
||||
[% IF ( show_barcode ) %]
|
||||
<td>
|
||||
<span class="tdlabel">Barcode:</span>
|
||||
[% OVERDUE.barcode | html %]
|
||||
</td>
|
||||
[% END %]
|
||||
<td>
|
||||
<span class="tdlabel">Call number:</span>
|
||||
[% OVERDUE.itemcallnumber | html %]
|
||||
</td>
|
||||
<td data-order="[% OVERDUE.date_due | html %]">
|
||||
<span class="tdlabel">Date due:</span>
|
||||
[% OVERDUE.date_due | $KohaDates as_due_date => 1 %]
|
||||
</td>
|
||||
[% IF ( OpacRenewalAllowed ) %]
|
||||
|
|
@ -822,7 +813,6 @@
|
|||
[% END %]
|
||||
[% IF ( OPACFinesTab ) %]
|
||||
<td>
|
||||
<span class="tdlabel">Fines:</span>
|
||||
[% IF ( OVERDUE.charges ) %]
|
||||
<span>Yes</span>
|
||||
[% ELSE %]
|
||||
|
|
@ -868,29 +858,24 @@
|
|||
</td>
|
||||
<td class="recalldate" data-order="[% RECALL.created_date | html %]">
|
||||
<span title="[% RECALL.created_date | html %]">
|
||||
<span class="tdlabel">Recall date:</span>
|
||||
[% RECALL.created_date | $KohaDates %]
|
||||
</span>
|
||||
</td>
|
||||
<td class="expirationdate" data-order="[% RECALL.expiration_date | html %]">
|
||||
[% IF ( RECALL.expiration_date ) %]
|
||||
<span title="[% RECALL.expiration_date | html %]">
|
||||
<span class="tdlabel">Expiration:</span>
|
||||
[% RECALL.expiration_date | $KohaDates %]
|
||||
</span>
|
||||
[% ELSE %]
|
||||
<span title="0000-00-00">
|
||||
<span class="tdlabel">Expiration:</span>
|
||||
Never expires
|
||||
</span>
|
||||
[% END %]
|
||||
</td>
|
||||
<td class="branch">
|
||||
<span class="tdlabel">Pick up location:</span>
|
||||
[% RECALL.library.branchname | html %]
|
||||
</td>
|
||||
<td class="status">
|
||||
<span class="tdlabel">Status:</span>
|
||||
[% IF ( RECALL.requested ) %]
|
||||
<span>Requested</span>
|
||||
[% ELSIF ( RECALL.overdue ) %]
|
||||
|
|
|
|||
Loading…
Reference in New Issue