gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 30633: Remove OPACHoldingsDefaultSortField 

It's no longer needed

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit b09ac4bf93)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Jonathan Druart 2025-10-14 11:26:27 +02:00 committed by Paul Derscheid
parent 34e976764d
commit 4e9bd0987e
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
4 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
installer/data/mysql/atomicupdate/bug_30633.pl Executable file
View File

@ -0,0 +1,19 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "30633",
description => "Remove system preference OPACHoldingsDefaultSortField",
up => sub {
my ($args) = @_;
my ( $dbh, $out ) = @$args{qw(dbh out)};
$dbh->do(
q{
DELETE FROM systempreferences
WHERE variable="OPACHoldingsDefaultSortField";
}
) == 1
&& say $out "Removed system preference 'OPACHoldingsDefaultSortField'";
},
};

1
installer/data/mysql/mandatory/sysprefs.sql
View File

@ -512,7 +512,6 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
('OpacHiddenItemsExceptions','',NULL,'List of borrower categories, separated by comma, that can see items otherwise hidden by OpacHiddenItems','Textarea'),
('OpacHiddenItemsHidesRecord','1','','Hide biblio record when all its items are hidden because of OpacHiddenItems','YesNo'),
('OpacHighlightedWords','1','','If Set, then queried words are higlighted in OPAC','YesNo'),
('OPACHoldingsDefaultSortField','first_column','first_column|homebranch|holdingbranch','Default sort field for the holdings table at the OPAC','choice'),
('OpacHoldNotes','0','','Show hold notes on OPAC','YesNo'),
('OPACHoldRequests','1',NULL,'If ON, globally enables patron holds on OPAC','YesNo'),
('OPACHoldsHistory','0','','If ON, enables display of Patron Holds History in OPAC','YesNo'),

7
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
View File

@ -317,13 +317,6 @@ OPAC:
homebranch: 'home library'
holdingbranch: 'holding library'
- "is the logged in patrons's library. The second tab will contain all other items."
-
- pref: OPACHoldingsDefaultSortField
choices:
first_column: First column of the table
homebranch: Home library
holdingbranch: Holding library
- "is the default sort field for the holdings table."
-
- Display up to
- pref: OpacMaxItemsToDisplay

9
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
View File

@ -1995,15 +1995,6 @@
});
[% END %]
[%# Note that there is no way atm to target a column with its class name to set it as the default sort order %]
[% IF Koha.Preference('OpacLocationBranchToDisplay') == 'home' AND Koha.Preference('OPACHoldingsDefaultSortField') == 'homebranch' AND item_level_itypes OR Koha.Preference('OpacLocationBranchToDisplay') == 'holding' AND Koha.Preference('OPACHoldingsDefaultSortField') == 'holdingbranch' AND item_level_itypes OR Koha.Preference('OpacLocationBranchToDisplay') == 'both' AND Koha.Preference('OPACHoldingsDefaultSortField') == 'homebranch' AND NOT item_level_itypes OR Koha.Preference('OpacLocationBranchToDisplay') == 'both' AND Koha.Preference('OPACHoldingsDefaultSortField') == 'holdingbranch' AND item_level_itypes %]
var default_order_index = 1;
[% ELSIF Koha.Preference('OpacLocationBranchToDisplay') == 'both' AND Koha.Preference('OPACHoldingsDefaultSortField') == 'homebranch' AND item_level_itypes %]
var default_order_index = 2;
[% ELSE %]
var default_order_index = 0;
[% END %]
[% IF ( query_desc ) %]
[% IF ( OpacHighlightedWords ) %]
var query_desc = "[% query_desc |replace("'", "\'") |replace('\n', '\\n') |replace('\r', '\\r') | html %]";