Bug 16078 [Revised] Remove unused YUI CSS

The YUI CSS file "skin.css" is no longer relevant to the staff client
templates and can be removed. Other references to YUI-related classes,
with the exception of grids, can also be removed.

This patch removes references in CSS to:

.yuimenuitemlabel
.yui-button
.yui-menu-button

...and removes the "yui-skin-sam" class from two templates' body tag.

skin.css is also included in a list of assets cached by the offline
circulation page. It can be safely removed.

To test, apply the patch and clear your cache if necessary. Look around
and confirm that the style of the staff client is unchanged.

Search for references to the listed classes and confirm that none are
found.

Revised patch squashes in the follow-up as well as a missing commit
removing skin.css from staff-global.css.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com

koha-tmpl/intranet-tmpl/prog/en/css/right-to-left.css

@@ -3,7 +3,6 @@ fieldset.rows ol.radio label, fieldset.rows li.radio label { float: right; margi
 
 /* Adjust text directions */
 
-a.yuimenuitemlabel,
 body,
 caption,
 div#toolbar,

koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css

@@ -1,5 +1,4 @@
 @import url("../lib/yui/reset-fonts-grids.css") screen;
-@import url("../lib/yui/skin.css");
 
 input:focus, textarea:focus {
     border-color:#538200;
@@ -20,22 +19,6 @@ a:hover, a:active {
     text-decoration: none;
 }
 
-.yui-button {
-    border-radius: 5px;
-}
-
-.yui-button .first-child {
-    border-radius: 5px;
-}
-
-.yui-button,.yui-button a:link,.yui-button a:visited {
-	color : #000;
-}
-
-a.yuimenuitemlabel {
-        color: #000000;
-}
-
 .overdue,
 .debit {
 	color : #cc0000;
@@ -426,11 +409,6 @@ div#toolbar,
     border: 1px solid #E6F0F2;
 }
 
-.btn-toolbar .yui-menu-button button,
-.btn-toolbar .yui-button-button button {
-    line-height : 1.7em;
-}
-
 ul.toolbar {
 	padding-left : 0;
 }
@@ -440,13 +418,13 @@ ul.toolbar button {
 	font-family: arial, verdana, helvetica, sans-serif;
 }
 
-a.yuimenuitemlabel-disabled, #disabled a {
+#disabled a {
 	color: #999;
 }
-a.yuimenuitemlabel-disabled, #disabled2 a {
+#disabled2 a {
  color: #999;
 }
-a.yuimenuitemlabel-disabled:hover, #disabled a:hover {
+#disabled a:hover {
 	color : #999;
 }
 a.highlight_toggle {
@@ -1561,11 +1539,6 @@ li.email {
 	padding : 5px 25em 0 0;
 }
 
-#searchheader .yui-button button,
-#searchheader .yui-button a {
-	line-height : 1.5em;
-}
-
 #search-facets ul {
 	margin : 0;
 	padding : .3em;
@@ -1717,11 +1690,6 @@ input.warning {
 	font-style : italic;
 }
 
-a.yuimenuitemlabel:hover {
-	background-color : #B3D4FF;
-	color : #000;
-}
-		
 #displayexample {
 	padding: 5px; 
 	margin-bottom: 10px;

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt

@@ -14,7 +14,7 @@
 </script>
 </head>
 
-<body id="cat_macles" class="yui-skin-sam cat" onload="Activate(0);load_macles();" >
+<body id="cat_macles" class="cat" onload="Activate(0);load_macles();" >
 
 <h1>Gestion des index MACLES</h1>
 <form name="f_pop" action="">

koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt

@@ -23,7 +23,6 @@ CACHE:
 [% themelang %]/js/staff-global.js
 [% interface %]/lib/jquery/plugins/jquery-ui-timepicker-addon.min.js
 [% themelang %]/lib/yui/reset-fonts-grids.css
-[% themelang %]/lib/yui/skin.css
 [% interface %]/prog/img/cart-small.gif
 [% interface %]/prog/img/glyphicons-halflings-koha.png
 [% interface %]/prog/img/koha-logo-medium.gif

koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt

@@ -77,7 +77,7 @@ $(document).ready(function() {
 //]]>
 </script>
 </head>
-<body id="ser_serials-collection" class="yui-skin-sam ser">
+<body id="ser_serials-collection" class="ser">
 [% INCLUDE 'header.inc' %]
 [% INCLUDE 'serials-search.inc' %]