gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 38394: Remove existing try/catch and say_failure from DB revs 

On bug 37895 we have failed to propose a solution to encapsulate exceptions and rethrow them.

Until this is ready we should not try/catch and so use say_failure from our DB revs.

We want to stop the DB update process when something is wrong. In those
try/catch we are actually continuing even if something bad happens.

As RaiseError is set on the dbh, say_failure statements will never be
reached.

Test plan:
checkout origin/24.05.0
reset_all
checkout main + this patch
updatedatabase

Everything should run fine.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2024-11-07 15:10:01 +01:00 committed by Katrin Fischer
parent fe495d19df
commit 4ccdb714ec
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
61 changed files with 93 additions and 132 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
installer/data/mysql/atomicupdate/skeleton.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "BUG_NUMBER",
@ -31,7 +31,6 @@ return {
say $out "Added 'XXX' HTML customization";
# Other information
say_failure( $out, "Use red for danger/failure" );
say_success( $out, "Use green for success" );
say_warning( $out, "Use yellow for warning/a call to action" );
say_info( $out, "Use blue for further information" );

2
installer/data/mysql/db_revs/231200044.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36120",

2
installer/data/mysql/db_revs/231200051.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "31097",

2
installer/data/mysql/db_revs/231200054.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "19768",

2
installer/data/mysql/db_revs/231200059.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36819",

2
installer/data/mysql/db_revs/231200060.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36665",

2
installer/data/mysql/db_revs/231200061.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "26176",

2
installer/data/mysql/db_revs/240600001.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36986",

2
installer/data/mysql/db_revs/240600002.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36453",

2
installer/data/mysql/db_revs/240600003.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "34597",

2
installer/data/mysql/db_revs/240600004.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "18493",

2
installer/data/mysql/db_revs/240600005.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "35639",

2
installer/data/mysql/db_revs/240600006.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "35597",

20
installer/data/mysql/db_revs/240600007.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36330",
@ -9,22 +9,14 @@ return {
my ( $dbh, $out ) = @$args{qw(dbh out)};
# Update columns, only changing the COMMENT
my $affected1 = $dbh->do(
$dbh->do(
q{ ALTER TABLE course_items MODIFY `location` varchar(80) DEFAULT NULL COMMENT 'new shelving location for the item to have while on reserve (optional)' }
);
if ($affected1) {
say_success( $out, "Comment for course_items.location was updated." );
} else {
say_failure( $out, "Comment for course_items.location was not updated." );
}
my $affected2 = $dbh->do(
say_success( $out, "Comment for course_items.location was updated." );
$dbh->do(
q{ ALTER TABLE course_items MODIFY `enabled` enum('yes','no') NOT NULL DEFAULT 'no' COMMENT 'if at least one enabled course has this item on reserve, this field will be ''yes'', otherwise it will be ''no''' }
);
if ($affected2) {
say_success( $out, "Comment for course_items.enabled was updated." );
} else {
say_failure( $out, "Comment for course_items.enabled was not updated." );
}
say_success( $out, "Comment for course_items.enabled was updated." );
},
};

2
installer/data/mysql/db_revs/240600008.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "35153",

2
installer/data/mysql/db_revs/240600009.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "33317",

2
installer/data/mysql/db_revs/240600010.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "34481",

2
installer/data/mysql/db_revs/240600011.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "37216",

2
installer/data/mysql/db_revs/240600012.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "26205",

2
installer/data/mysql/db_revs/240600013.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "18317",

2
installer/data/mysql/db_revs/240600014.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "33363",

2
installer/data/mysql/db_revs/240600015.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36453",

2
installer/data/mysql/db_revs/240600016.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "28924",

2
installer/data/mysql/db_revs/240600017.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "13888",

2
installer/data/mysql/db_revs/240600018.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
use Array::Utils qw( array_minus );
return {

2
installer/data/mysql/db_revs/240600019.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "23781",

2
installer/data/mysql/db_revs/240600020.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36996",

2
installer/data/mysql/db_revs/240600021.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "35539",

2
installer/data/mysql/db_revs/240600022.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "37419",

2
installer/data/mysql/db_revs/240600023.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36757",

2
installer/data/mysql/db_revs/240600024.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "35044",

2
installer/data/mysql/db_revs/240600025.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "26777",

2
installer/data/mysql/db_revs/240600026.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "20411",

2
installer/data/mysql/db_revs/240600027.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "27490",

2
installer/data/mysql/db_revs/240600028.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "37757",

23
installer/data/mysql/db_revs/240600029.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => '37592',
@ -31,17 +31,11 @@ return {
ALTER TABLE bookings ADD COLUMN modification_date DATETIME DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'The datetime for when a booking has been updated'
SQL
if ( @{$existing_columns} == 0 ) {
if ( $dbh->do("$creation_date_statement AFTER `end_date`") ) {
say_success( $out, q{Added column 'bookings.creation_date'} );
} else {
say_failure( $out, q{Failed to add column 'bookings.creation_date': } . $dbh->errstr );
}
$dbh->do("$creation_date_statement AFTER `end_date`");
say_success( $out, q{Added column 'bookings.creation_date'} );
if ( $dbh->do("$modification_date_statement AFTER `creation_date`") ) {
say_success( $out, q{Added column 'bookings.modification_date'} );
} else {
say_failure( $out, q{Failed to add column 'bookings.modification_date': } . $dbh->errstr );
}
$dbh->do("$modification_date_statement AFTER `creation_date`");
say_success( $out, q{Added column 'bookings.modification_date'} );
return;
}
@ -61,11 +55,8 @@ return {
$statement = "$modification_date_statement AFTER `creation_date`";
}
if ( $dbh->do($statement) ) {
say_success( $out, "Added column 'bookings.$column'" );
} else {
say_failure( $out, "Failed to add column 'bookings.$column': " . $dbh->errstr );
}
$dbh->do($statement);
say_success( $out, "Added column 'bookings.$column'" );
}
}
},

9
installer/data/mysql/db_revs/240600030.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => '37601',
@ -20,10 +20,7 @@ return {
ALTER TABLE `bookings`
ADD COLUMN `status` ENUM('new', 'cancelled', 'completed') NOT NULL DEFAULT 'new' COMMENT 'current status of the booking' $after;
SQL
if ( $dbh->do($statement) ) {
say_success( $out, q{Added column 'bookings.status'} );
} else {
say_failure( $out, q{Failed to add column 'bookings.status'} );
}
$dbh->do($statement);
say_success( $out, q{Added column 'bookings.status'} );
},
};

2
installer/data/mysql/db_revs/240600031.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "23685",

2
installer/data/mysql/db_revs/240600032.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "37856",

2
installer/data/mysql/db_revs/240600033.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "35655",

22
installer/data/mysql/db_revs/240600034.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "37967",
@ -8,17 +8,13 @@ return {
my ($args) = @_;
my ( $dbh, $out ) = @$args{qw(dbh out)};
try {
$dbh->do(
q{
INSERT IGNORE INTO message_transports (`message_attribute_id`, `message_transport_type`, `is_digest`, `letter_module`, `letter_code`) VALUES
(9, 'phone', 1, 'circulation', 'AUTO_RENEWALS_DGST'),
(9, 'phone', 0, 'circulation', 'AUTO_RENEWALS');
}
);
say_success( $out, "Added phone messaging transports for auto-renewals" );
} catch {
say_failure( $out, "Error adding phone messaging transports for auto-renewals: $_" );
};
$dbh->do(
q{
INSERT IGNORE INTO message_transports (`message_attribute_id`, `message_transport_type`, `is_digest`, `letter_module`, `letter_code`) VALUES
(9, 'phone', 1, 'circulation', 'AUTO_RENEWALS_DGST'),
(9, 'phone', 0, 'circulation', 'AUTO_RENEWALS');
}
);
say_success( $out, "Added phone messaging transports for auto-renewals" );
},
};

2
installer/data/mysql/db_revs/240600036.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "37954",

2
installer/data/mysql/db_revs/240600037.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36798",

2
installer/data/mysql/db_revs/240600038.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "36766",

2
installer/data/mysql/db_revs/240600039.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "28575",

14
installer/data/mysql/db_revs/240600040.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "23295",
@ -14,14 +14,10 @@ return {
say_success ( $out, "Added new system preference 'RestrictPatronsWithFailedNotices'" );
try {
$dbh->do(
q{INSERT IGNORE INTO restriction_types (code, display_text, is_system, is_default) VALUES ('NOTICE_FAILURE_SUSPENSION', 'Notice failure suspension', 1, 0)}
);
say_success( $out, "Added new system restriction type 'NOTICE_FAILURE_SUSPENSION'" );
} catch {
say_failure( $out, "Database modification failed with errors: $_" );
};
$dbh->do(
q{INSERT IGNORE INTO restriction_types (code, display_text, is_system, is_default) VALUES ('NOTICE_FAILURE_SUSPENSION', 'Notice failure suspension', 1, 0)}
);
say_success( $out, "Added new system restriction type 'NOTICE_FAILURE_SUSPENSION'" );
},
};

2
installer/data/mysql/db_revs/240600041.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "30955",

2
installer/data/mysql/db_revs/240600042.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "37969",

9
installer/data/mysql/db_revs/240600043.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => '38193',
@ -18,10 +18,7 @@ return {
ALTER TABLE `bookings`
ADD COLUMN `cancellation_reason` varchar(80) DEFAULT NULL COMMENT 'optional authorised value BOOKING_CANCELLATION' AFTER `status`;
SQL
if ( $dbh->do($statement) ) {
say_success( $out, q{Added column 'bookings.cancellation_reason'} );
} else {
say_failure( $out, q{Failed to add column 'bookings.cancellation_reason'} );
}
$dbh->do($statement);
say_success( $out, q{Added column 'bookings.cancellation_reason'} );
},
};

2
installer/data/mysql/db_revs/240600044.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => '28833',

2
installer/data/mysql/db_revs/240600045.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "35906",

2
installer/data/mysql/db_revs/240600046.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "38222",

2
installer/data/mysql/db_revs/240600047.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "35659",

2
installer/data/mysql/db_revs/240600048.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "33484",

2
installer/data/mysql/db_revs/240600049.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "38274",

2
installer/data/mysql/db_revs/240600050.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "30648",

2
installer/data/mysql/db_revs/240600051.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "14180",

2
installer/data/mysql/db_revs/240600052.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "35305",

19
installer/data/mysql/db_revs/240600053.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
use Try::Tiny;
return {
@ -10,19 +10,12 @@ return {
my ( $dbh, $out ) = @$args{qw(dbh out)};
if ( !column_exists( 'currency', 'p_cs_precedes' ) ) {
try {
$dbh->do(
q{
$dbh->do(
q{
ALTER TABLE `currency` ADD COLUMN `p_cs_precedes` tinyint(1) DEFAULT 1 AFTER p_sep_by_space
}
);
say_success( $out, "Added column 'currency.p_cs_precedes'" );
} catch {
say_failure(
$out,
"Adding column 'currency.p_cs_precedes' failed with errors: $_"
);
};
}
);
say_success( $out, "Added column 'currency.p_cs_precedes'" );
} else {
say_info( $out, "Column 'currency.p_cs_precedes' already exists" );
}

2
installer/data/mysql/db_revs/240600054.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
use C4::Context;
use Koha::Reports;

2
installer/data/mysql/db_revs/240600055.pl
View File

@ -1,5 +1,5 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
use Koha::Installer::Output qw(say_warning say_success say_info);
return {
bug_number => "33462",