gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20444: Use Koha::Patron::Attribute::Types object for getting patron attributes in letter.pl 

Test plan:
0) Apply the patch
1) Do not have any patron attribute types defined
2) Go to Tools -> Notices and slips
3) Edit any slip/letter which uses table borrower
4) Confirm the editing works, and the slip/letter itself works
5) Add some patron attributes types and define them a value for any
patron
6) Go to Tools -> Notices and slips and edit any slip/letter which uses
table borrower
7) Confirm, the attributes are listed in available fields
8) Confirm the slip/letter is working when you add a attribute to it

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Josef Moravec 2018-03-19 09:27:07 +00:00 committed by Jonathan Druart
parent 60e5a8a2ab
commit 4c3a257448
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tools/letter.pl
View File

@ -46,7 +46,8 @@ use C4::Auth;
use C4::Context;
use C4::Output;
use C4::Letters;
use C4::Members::Attributes;
use Koha::Patron::Attribute::Types;
# $protected_letters = protected_letters()
# - return a hashref of letter_codes representing letters that should never be deleted
@ -466,12 +467,14 @@ sub get_columns_for {
}
}
if ($table eq 'borrowers') {
if ( my $attributes = C4::Members::Attributes::GetAttributes() ) {
foreach (@$attributes) {
push @fields, {
value => "borrower-attribute:$_",
text => "attribute:$_",
}
my $attribute_types = Koha::Patron::Attribute::Types->search(
{},
{ order_by => 'code' },
);
while ( my $at = $attribute_types->next ) {
push @fields, {
value => "borrower-attribute:" . $at->code,
text => "attribute:" . $at->code,
}
}
}