gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20128: (QA follow-up) Corrections to haspermission 

The haspermission routine wrongly assumed that get_user_subpermissions
would return a list of all subpermissions if the user had the top level
permission, but instead if just returns 1.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2019-03-21 10:16:34 +00:00 committed by Nick Clemens
parent 8f8367c728
commit 4c01891613
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
C4/Auth.pm
View File

@ -2066,6 +2066,7 @@ sub _dispatch {
}
} elsif ($ref eq 'HASH') {
foreach my $key (keys %{$required}) {
next if $flags == 1;
my $require = $required->{$key};
my $rflags = $flags->{$key};
return 0 unless _dispatch($require, $rflags);
@ -2090,7 +2091,6 @@ sub _dispatch {
sub haspermission {
my ( $userid, $flagsrequired ) = @_;
#Koha::Exceptions::WrongParameter->throw('$flagsrequired should not be undef')
# unless defined($flagsrequired);

2
t/db_dependent/Auth/haspermission.t
View File

@ -111,7 +111,7 @@ subtest 'scalar top level tests' => sub {
subtest 'hashref top level AND tests' => sub {
plan tests => 15;
plan tests => 16;
# Check top level permission for superlibrarian
my $r =