gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 27032: (follow-up) Pass rather than fetch variables 

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2021-03-22 13:29:13 +00:00 committed by Jonathan Druart
parent c862fd1382
commit 478ffeae60
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
C4/Circulation.pm
View File

@ -2786,7 +2786,12 @@ sub CanBookBeRenewed {
return ( 0, 'overdue');
}
$auto_renew = _CanBookBeAutoRenewed($borrowernumber, $itemnumber);
$auto_renew = _CanBookBeAutoRenewed({
patron => $patron,
item => $item,
branchcode => $branchcode,
issue => $issue
});
return ( 0, $auto_renew ) if $auto_renew =~ 'auto_account_expired';
return ( 0, $auto_renew ) if $auto_renew =~ 'auto_too_late';
return ( 0, $auto_renew ) if $auto_renew =~ 'auto_too_much_oweing';
@ -4238,12 +4243,11 @@ sub _CalculateAndUpdateFine {
}
sub _CanBookBeAutoRenewed {
my ( $borrowernumber, $itemnumber ) = @_;
my $item = Koha::Items->find($itemnumber);
my $issue = $item->checkout;
my $patron = $issue->patron;
my $branchcode = _GetCircControlBranch( $item->unblessed, $patron->unblessed );
my ( $params ) = @_;
my $patron = $params->{patron};
my $item = $params->{item};
my $branchcode = $params->{branchcode};
my $issue = $params->{issue};
my $issuing_rule = Koha::CirculationRules->get_effective_rules(
{