gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 23404: add UT to show bug 

Run prove t/db_dependent/Circulation/TooMany.t
It fails on :
    #   Failed test 'We are only allowed one, and we have one (itemtype on biblioitem)'
    #   at t/db_dependent/Circulation/TooMany.t line 547.
    #     Structures begin differing at:
    #          $got->{reason} = 'NO_RULE_DEFINED'
    #     $expected->{reason} = 'TOO_MANY_CHECKOUTS'

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Fridolin Somers 2019-07-31 11:21:14 +02:00 committed by Martin Renvoize
parent 811bee9bce
commit 445b0cb8b5
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
t/db_dependent/Circulation/TooMany.t
View File

@ -466,7 +466,7 @@ subtest '1 BranchBorrowerCircRule exist: 1 CO allowed, 1 OSCO allowed' => sub {
};
subtest 'General vs specific rules limit quantity correctly' => sub {
plan tests => 9;
plan tests => 10;
t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
my $branch = $builder->build({source => 'Branch',});
@ -516,7 +516,7 @@ subtest 'General vs specific rules limit quantity correctly' => sub {
);
# Create an item
my $item = $builder->build_sample_item({
my $issue_item = $builder->build_sample_item({
itype => $itemtype->{itemtype}
});
my $branch_item = $builder->build_sample_item({
@ -527,7 +527,7 @@ subtest 'General vs specific rules limit quantity correctly' => sub {
t::lib::Mocks::mock_userenv({ branchcode => $branch->{branchcode} });
my $issue = C4::Circulation::AddIssue( $patron, $item->barcode, dt_from_string() );
my $issue = C4::Circulation::AddIssue( $patron, $issue_item->barcode, dt_from_string() );
# We checkout one item
is_deeply(
C4::Circulation::TooMany( $patron, $branch_item->biblionumber, $branch_item->unblessed ),
@ -536,9 +536,24 @@ subtest 'General vs specific rules limit quantity correctly' => sub {
count => 1,
max_allowed => 1,
},
'We are only allowed one, and we have one'
'We are only allowed one, and we have one (itemtype on item)'
);
# Check itemtype on biblio level
t::lib::Mocks::mock_preference('item-level_itypes', 0);
$issue_item->biblio->biblioitem->itemtype($itemtype->{itemtype})->store;
$branch_item->biblio->biblioitem->itemtype($itemtype->{itemtype})->store;
# We checkout one item
is_deeply(
C4::Circulation::TooMany( $patron, $branch_item->biblionumber, $branch_item->unblessed ),
{
reason => 'TOO_MANY_CHECKOUTS',
count => 1,
max_allowed => 1,
},
'We are only allowed one, and we have one (itemtype on biblioitem)'
);
t::lib::Mocks::mock_preference('item-level_itypes', 1);
# Set a branch specific rule
Koha::CirculationRules->set_rules(