gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 42366: Fix debug_mode test for koha-conf.xml 

This patch fixes the debug_mode test for koha-conf.xml,
so that <debug_mode>0</debug_mode> works properly.

Test plan:
0. Do not apply the patch
1. sudo vi /etc/koha/sites/kohadev/koha-conf.xml
2. Change <debug_mode>1</debug_mode> to
<debug_mode>0</debug_mode>
3. sudo koha-plack --restart kohadev
4. ps -efww | grep "starman"
5. Note that starman is still in development mode

6. Apply the patch
7. sudo koha-plack --restart kohadev
8. ps -efww | grep "starman"
9. Note that starman is now in deployment mode

Note: this is important because running a production
system in debug/development mode can be a security risk!

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
David Cook 2026-04-15 06:25:16 +00:00 committed by Lucas Gass
parent dbbc1aa53e
commit 41d84f621d
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
debian/scripts/koha-functions.sh vendored
View File

@ -414,7 +414,7 @@ is_debug_mode()
if [ "$instancename" != "" ] && is_instance $instancename; then
debug_mode=$(run_safe_xmlstarlet $instancename debug_mode)
fi
if [ -n "$debug_mode" ] && [ "debug_mode" != "0" ]; then
if [ -n "$debug_mode" ] && [ "$debug_mode" != "0" ]; then
return 0; # true
else
return 1