gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 36515: (QA follow-up) Tidy code 

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Kyle M Hall 2024-07-19 08:57:54 -04:00 committed by Katrin Fischer
parent 4923a5841e
commit 411a885829
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
2 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Koha/SimpleMARC.pm
View File

@ -135,12 +135,12 @@ sub copy_and_replace_field {
if ( ! ( $record && $fromFieldName && $toFieldName ) ) { return; }
if (
( !defined $fromSubfieldName or $fromSubfieldName eq '' )
and ( !defined $toSubfieldName or $toSubfieldName eq '' )
) {
if ( ( !defined $fromSubfieldName or $fromSubfieldName eq '' )
and ( !defined $toSubfieldName or $toSubfieldName eq '' ) )
{
_copy_move_field(
{ record => $record,
{
record => $record,
from_field => $fromFieldName,
to_field => $toFieldName,
regex => $regex,
@ -150,7 +150,8 @@ sub copy_and_replace_field {
);
} else {
_copy_move_subfield(
{ record => $record,
{
record => $record,
from_field => $fromFieldName,
from_subfield => $fromSubfieldName,
to_field => $toFieldName,

9
t/SimpleMARC.t
View File

@ -1526,14 +1526,9 @@ subtest 'copy_and_replace_field' => sub {
);
# Copy control field to subfield
copy_and_replace_field(
{ record => $record, from_field => '001', to_field => '099', to_subfield => 'a' } );
copy_and_replace_field( { record => $record, from_field => '001', to_field => '099', to_subfield => 'a' } );
is_deeply(
[
read_field(
{ record => $record, field => '099', subfield => 'a' }
)
],
[ read_field( { record => $record, field => '099', subfield => 'a' } ) ],
['4815162342'],
'Copy and replace - Update a subfield with content of control field'
);