From 4112dde9413eb84fbfb784f33aa68a790817a2e4 Mon Sep 17 00:00:00 2001 From: Maryse Simard Date: Thu, 26 Mar 2026 10:23:50 -0400 Subject: [PATCH] Bug 42193: Fix the "Suspend Hold" modal in the OPAC In the OPAC, the "Suspend Hold" modal sometimes shows up as (and acts like) a "Resume Hold" modal. The reason for this is a left over "HOLD.suspend" in the template. "HOLD" should not be used in this template and is set as a side effect of the processing of "holds-table.inc". Since there is a separate form that exist for the "Resume" action and the modal is only needed for suspension, this patch simply removes the inacurate conditional in the modal definition. To test : 1. Have at least 2 holds. 2. In the holds table in the OPAC, make sure all holds are active and have a "Suspend" link. 3. Click the "Suspend" link on the newest hold (with the highest reserve_id). => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. 4. Click the "Suspend" link on any of the other hold. => The modal is titled "Resume hold" and submitting it doesn't suspends the hold. 5. Apply patch 6. Repeat step 4. => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt index 5cdb32eaa6..0ce4456887 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt @@ -1032,13 +1032,8 @@
[% INCLUDE 'csrf-token.inc' %]
- [% IF HOLD.suspend %] -

Resume hold

- - [% ELSE %] -

Suspend hold

- - [% END %] +

Suspend hold

+