From 3e404686206c556a99cf72970620da19ae7c2a61 Mon Sep 17 00:00:00 2001
From: Paul Derscheid <paul.derscheid@lmscloud.de>
Date: Thu, 25 Sep 2025 15:54:31 +0200
Subject: [PATCH] Revert "Bug 36135: Add batch_modify_holds permissions"

This reverts commit 21917b5d9e4a26ff82457c1e86dc95a4f7f6e306.

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
---
 installer/data/mysql/atomicupdate/bug_36135.pl   | 16 ----------------
 .../data/mysql/mandatory/userpermissions.sql     |  1 -
 .../prog/en/includes/permissions.inc             |  5 -----
 3 files changed, 22 deletions(-)
 delete mode 100755 installer/data/mysql/atomicupdate/bug_36135.pl

diff --git a/installer/data/mysql/atomicupdate/bug_36135.pl b/installer/data/mysql/atomicupdate/bug_36135.pl
deleted file mode 100755
index 40aa318e1e..0000000000
--- a/installer/data/mysql/atomicupdate/bug_36135.pl
+++ /dev/null
@@ -1,16 +0,0 @@
-use Modern::Perl;
-
-return {
-    bug_number  => "36135",
-    description => "Add new permission batch_modify_holds",
-    up          => sub {
-        my ($args) = @_;
-        my ( $dbh, $out ) = @$args{qw(dbh out)};
-
-        $dbh->do(
-            q{INSERT IGNORE permissions (module_bit, code, description) VALUES (13, 'batch_modify_holds', 'Perform batch modification of holds')}
-        );
-
-        say $out "Added new permission 'batch_modify_holds'";
-    },
-};
diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql
index 87ce0a84d3..1ff3f33d1e 100644
--- a/installer/data/mysql/mandatory/userpermissions.sql
+++ b/installer/data/mysql/mandatory/userpermissions.sql
@@ -113,7 +113,6 @@ INSERT INTO permissions (module_bit, code, description) VALUES
    (13, 'edit_patrons', 'Perform batch modification of patrons'),
    (13, 'delete_anonymize_patrons', 'Delete old borrowers and anonymize circulation history (deletes borrower checkout history)'),
    (13, 'batch_extend_due_dates', 'Perform batch extend due dates'),
-   (13, 'batch_modify_holds', 'Perform batch modification of holds'),
    (13, 'batch_upload_patron_images', 'Upload patron images in a batch or one at a time'),
    (13, 'schedule_tasks', 'Schedule tasks to run'),
    (13, 'items_batchmod', 'Perform batch modification of items'),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
index 5d77b6708c..aa331ee7cf 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
@@ -371,11 +371,6 @@
     [%- CASE 'batch_extend_due_dates' -%]
         <span class="sub_permission batch_extend_due_dates_subpermission"> Perform batch extend due dates </span>
         <span class="permissioncode">([% name | html %])</span>
-    [%- CASE 'batch_modify_holds' -%]
-        <span class="sub_permission batch_modify_holds_subpermission">
-            Perform batch modification of holds
-        </span>
-        <span class="permissioncode">([% name | html %])</span
     [%- CASE 'edit_calendar' -%]
         <span class="sub_permission edit_calendar_subpermission"> Define days when the library is closed </span>
         <span class="permissioncode">([% name | html %])</span>