gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24901: Fix tests for 19.11.x 

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2020-04-07 15:37:13 +02:00 committed by Joy Nelson
parent 44352f319e
commit 3b697742db
1 changed files with 22 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
t/db_dependent/Circulation/transferbook.t
View File

@ -17,7 +17,7 @@
use Modern::Perl;
use Test::More tests => 5;
use Test::More tests => 4;
use t::lib::TestBuilder;
use t::lib::Mocks;
@ -81,12 +81,13 @@ subtest 'transfer already at destination' => sub {
# We are making sure there is no regression, feel free to change the behavior if needed.
# * Contrary to the POD, if ignore_reserves is not passed (or is false), any item reserve
# found will override all other measures that may prevent transfer and force a transfer.
AddReserve({
branchcode => $item->homebranch,
borrowernumber => $patron->borrowernumber,
biblionumber => $item->biblionumber,
itemnumber => $item->itemnumber,
});
AddReserve(
$item->homebranch,
$patron->borrowernumber,
$item->biblionumber,
undef, undef, undef, undef, undef, undef,
$item->itemnumber,
);
($dotransfer, $messages ) = transferbook( $library->branchcode, $item->barcode );
is( $dotransfer, 1, 'Transfer of reserved item succeeded without ignore reserves' );
@ -128,12 +129,13 @@ subtest 'transfer an issued item' => sub {
# We are making sure there is no regression, feel free to change the behavior if needed.
# * Contrary to the POD, if ignore_reserves is not passed (or is false), any item reserve
# found will override all other measures that may prevent transfer and force a transfer.
AddReserve({
branchcode => $item->homebranch,
borrowernumber => $patron->borrowernumber,
biblionumber => $item->biblionumber,
itemnumber => $item->itemnumber,
});
AddReserve(
$item->homebranch,
$patron->borrowernumber,
$item->biblionumber,
undef, undef, undef, undef, undef, undef,
$item->itemnumber,
);
($dotransfer, $messages ) = transferbook( $library->branchcode, $item->barcode );
is( $dotransfer, 1, 'Transfer of reserved item succeeded without ignore reserves' );
@ -160,12 +162,13 @@ subtest 'ignore_reserves flag' => sub {
}
);
AddReserve({
branchcode => $item->homebranch,
borrowernumber => $patron->borrowernumber,
biblionumber => $item->biblionumber,
itemnumber => $item->itemnumber,
});
AddReserve(
$item->homebranch,
$patron->borrowernumber,
$item->biblionumber,
undef, undef, undef, undef, undef, undef,
$item->itemnumber,
);
# We are making sure there is no regression, feel free to change the behavior if needed.
# * Contrary to the POD, if ignore_reserves is not passed (or is false), any item reserve