gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40118: Prevent adding another empty value option 

This is already done for all select dropdowns by default. If a
particular table provides an empty value it should be skipped or 2
empty options may show

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 082274d157)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Pedro Amorim 2025-06-11 14:17:05 +00:00 committed by Paul Derscheid
parent d334d9ebaa
commit 388a9f3640
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 24 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
koha-tmpl/intranet-tmpl/prog/js/datatables.js
View File

@ -1057,27 +1057,31 @@ function _dt_add_filters(table_node, table_dt, filters_options = {}) {
} else if (typeof filters_options[i] === "function") {
filters_options[i] = filters_options[i](table_dt);
}
$(filters_options[i]).each(function () {
let optionValue =
table_dt.settings()[0].ajax !== null
? `^${this._id}$`
: this._id;
let o = $(
`<option value="${optionValue}">${this._str}</option>`
);
$(filters_options[i])
.filter(function () {
return this._id && this._str;
})
.each(function () {
let optionValue =
table_dt.settings()[0].ajax !== null
? `^${this._id}$`
: this._id;
let o = $(
`<option value="${optionValue}">${this._str}</option>`
);
// Compare with lc, or selfreg won't match ^SELFREG$ for instance, see bug 32517
// This is only for category, we might want to apply it only in this case.
existing_search = existing_search.toLowerCase();
if (
existing_search === this._id ||
(existing_search &&
this._id.toLowerCase().match(existing_search))
) {
o.prop("selected", "selected");
}
o.appendTo(select);
});
// Compare with lc, or selfreg won't match ^SELFREG$ for instance, see bug 32517
// This is only for category, we might want to apply it only in this case.
existing_search = existing_search.toLowerCase();
if (
existing_search === this._id ||
(existing_search &&
this._id.toLowerCase().match(existing_search))
) {
o.prop("selected", "selected");
}
o.appendTo(select);
});
$(th).html(select);
} else {
var title = $(th).text();