gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 37364: Unit tests 

This patch adds unit tests to confirm that the 773 record created by
Koha::Biblio now takes account of RDA updates and subfield ordering.

Test plan
1. Apply patch
2. Run `prove ./t/db_dependent/Koha/Biblio.t`.
3. Test fails.
4. Apply next patch in series
5. Run `prove ./t/db_dependent/Koha/Biblio.t`.
6. All tests pass.

Signed-off-by: Lin Wei Li <lin-wei.li@inLibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f234fe5a1c)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Martin Renvoize 2024-07-17 09:57:53 +01:00 committed by Paul Derscheid
parent 1c62677aa0
commit 3826b4794e
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
t/db_dependent/Koha/Biblio.t
View File

@ -1016,7 +1016,7 @@ subtest 'get_volumes_query' => sub {
};
subtest 'generate_marc_host_field' => sub {
plan tests => 22;
plan tests => 24;
$schema->storage->txn_begin;
@ -1028,7 +1028,7 @@ subtest 'generate_marc_host_field' => sub {
MARC::Field->new( '001', '1234' ),
MARC::Field->new( '003', 'FIRST' ),
MARC::Field->new( '240', '', '', a => 'A uniform title' ),
MARC::Field->new( '260', '', '', a => 'Publication' ),
MARC::Field->new( '260', '', '', a => 'Publication 260' ),
MARC::Field->new( '250', '', '', a => 'Edition a', b => 'Edition b' ),
MARC::Field->new( '022', '', '', a => '0317-8471' ),
);
@ -1042,7 +1042,7 @@ subtest 'generate_marc_host_field' => sub {
is( $link->tag, '773', "MARC::Field->tag returns '773' when marcflavour is 'MARC21" );
is( $link->subfield('a'), 'Some boring author', 'MARC::Field->subfield(a) returns content from 100ab' );
is( $link->subfield('b'), 'Edition a Edition b', 'MARC::Field->subfield(b) returns content from 250ab' );
is( $link->subfield('d'), 'Publication', 'MARC::Field->subfield(c) returns content from 260abc' );
is( $link->subfield('d'), 'Publication 260', 'MARC::Field->subfield(c) returns content from 260abc' );
is( $link->subfield('s'), 'A uniform title', 'MARC::Field->subfield(s) returns content from 240a' );
is( $link->subfield('t'), 'Some boring read', 'MARC::Field->subfield(s) returns content from 245ab' );
is( $link->subfield('x'), '0317-8471', 'MARC::Field->subfield(s) returns content from 022a' );
@ -1056,6 +1056,30 @@ subtest 'generate_marc_host_field' => sub {
'MARC::Field->subfield(w) returns content from 003 and 001 when "UseControlNumber" is enabled'
);
$record->append_fields(
MARC::Field->new( '264', '', '', a => 'Publication 264' ),
);
C4::Biblio::ModBiblio( $record, $biblio->biblionumber );
$biblio = Koha::Biblios->find( $biblio->biblionumber );
$link = $biblio->generate_marc_host_field();
is(
$link->subfield('d'), 'Publication 264',
'MARC::Field->subfield(d) returns content from 264 in preference to 260'
);
$record->append_fields(
MARC::Field->new( '264', '3', '', a => 'Publication 264', b => 'Preferred' ),
);
C4::Biblio::ModBiblio( $record, $biblio->biblionumber );
$biblio = Koha::Biblios->find( $biblio->biblionumber );
$link = $biblio->generate_marc_host_field();
is(
$link->subfield('d'), 'Publication 264 Preferred',
'MARC::Field->subfield(d) returns content from 264 with indicator 1 = 3 in preference to 264 without'
);
# UNIMARC tests
t::lib::Mocks::mock_preference( 'marcflavour', 'UNIMARC' );