From 37ca2fb91c8c03727e6cd983388d96c414986ed9 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 6 Oct 2025 09:31:47 +0200 Subject: [PATCH] Bug 40939: Fix batch actions from report results Batch patron operations are broken when using cardnumbers From commit d659526b5ae3363de6dc7691a782a45aaf781a46 Bug 38664: Tidy the whole codebase - [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] -[%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] + [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] + [%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] The auto tidy added the whitespaces back This patch suggests to use TT to add the new lines. + [%- cells.cell | html -%][% "\n" | $raw %][%# We want 1 item per line, without whitespace %] Test plan: - save and run "SELECT cardnumber FROM borrowers" - use the Batch Operations button to send all visible cardnumbers to batch patron modification - see that all of your cardnumbers have been found Signed-off-by: Brendan Lawlor Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass (cherry picked from commit d79cf5665db63faa40071f251f7e1540b953765d) Signed-off-by: Paul Derscheid --- .../prog/en/modules/reports/guided_reports_start.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index df14097414..f2cf2280f9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -1075,9 +1075,9 @@ [%- FOREACH result IN results %] [%- FOREACH cells IN result.cells %] [%- place = loop.index %] - [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %] - [%# We must not add whitespace to the cardnumbers %][% cells.cell | html %] - [%- END %] + [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type -%] + [%- cells.cell | html -%][% "\n" | $raw %][%# We want 1 item per line, without whitespace %] + [%- END -%] [%- END %] [%- END -%] [% END %]