gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 38148: Check value of holdallowed circ rule properly 

It was noted on Bug 29087 that the value of circulation rules needs to be checked differently, so this follow-up addresses that.

To test:

1. Apply patch and restart services
2. Search for a record on the OPAC. Confirm you can see a link to place a hold.
3. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list.
4. Confirm tests still pass t/db_dependent/Koha/Holds.t

Sponsored-by: Whanganui District Council
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: andrewa <andrew.auld@ptfs-europe.com>
Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit e2be4e00a5)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Aleisha Amohia 2024-10-11 01:53:11 +00:00 committed by Lucas Gass
parent f8b6777e50
commit 3748fe30df
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Koha/Items.pm
View File

@ -61,14 +61,16 @@ placing a hold on one of those items.
sub filter_by_for_hold {
my ($self) = @_;
my $default_rule = Koha::CirculationRules->get_effective_rule(
my $default_rule = Koha::CirculationRules->get_effective_rule_value(
{
rule_name => 'holdallowed',
rule_value => 'not_allowed',
itemtype => undef,
branchcode => undef,
categorycode => undef,
}
);
my @hold_not_allowed_itypes;
if ($default_rule) {
if ($default_rule eq 'not_allowed') {
@hold_not_allowed_itypes = Koha::ItemTypes->search->get_column('itemtype');
my @hold_allowed_itypes = Koha::CirculationRules->search(
{