gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40654: Fix how rank/priority is adjusted when changing from the UI 

To test:
0 - APPLY PATCH
1 - Place 50 holds on a bib record
https://github.com/kidclamp/handy-koha-script/blob/main/randhold.pl
2 - View the holds page for the record
3 - Sort the holds alphabetically
4 - Change the dropdown priortiy for the alphabetically first hold to 1
5 - All the priorities should now ajust accordingly but they will NOT be resorted on the fly
6 - Play with adjusting some priorities, making sure everything correctly adjusts.
7 - Click 'Update holds' to make sure the priorities adjust right
8 - Make sure you test with the 'del' option and the adjustments still work.

Signed-off-by: David Flater <flaterdavid@gmail.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 4b38f5acd5)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Lucas Gass 2025-08-14 18:42:17 +00:00 committed by Paul Derscheid
parent df6768d616
commit 369f8ae6e2
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 47 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View File

@ -1756,27 +1756,57 @@
});
var prev_rank_request;
$("select[name=rank-request]").on("focus", function() {
prev_rank_request = $(this).val();
var row = $(this).parents("tr:first");
prev_rank_request = parseInt($(this).val());
}).change(function() {
var row = $(this).parents("tr:first");
var value = parseInt($(this).val());
var found_holds = $("select[name='rank-request'][disabled='disabled']").length ; //Count how many are found
if( !isNaN(value) ) { //If moved to 'del'
var after = row.parent().find(`tr:nth-child(${value+found_holds})`); //Go to the row 1 after the new value (and skip found holds)
if (prev_rank_request > value) {
row.insertBefore(after);
} else {
row.insertAfter(after);
}
var this_rank = $(this);
var new_rank = parseInt(this_rank.val());
var old_rank = prev_rank_request;
if ( isNaN( old_rank ) ) {
$("select[name=rank-request]").not('[disabled]').not(this_rank).each(function() {
var current_rank = parseInt($(this).val());
if ( !isNaN(current_rank) && current_rank >= new_rank ) {
$(this).val(current_rank + 1);
}
});
prev_rank_request = new_rank;
return;
}
var next_priority = 1;
$("select[name=rank-request]").each(function () {
if( isNaN( $(this).val() ) ){ return true; } //Don't reset found or del holds
$(this).val(next_priority);
next_priority++;
if ( isNaN( new_rank ) ) {
if ( !isNaN( old_rank ) ) {
$("select[name=rank-request]").not('[disabled]').not(this).each(function() {
var current_rank = parseInt($(this).val());
if ( !isNaN(current_rank) && current_rank > old_rank ) {
$(this).val(current_rank - 1);
}
});
}
prev_rank_request = NaN;
return;
}
//if new rank is old rank, don't continue
if ( new_rank === old_rank ) return;
// Adjust ranks
$("select[name=rank-request]").not('[disabled]').not(this).each(function() {
var current_rank = parseInt($(this).val());
//if current_rank is NaN, bail
if ( isNaN( current_rank ) ) return;
if ( old_rank > new_rank ) {
if ( current_rank >= new_rank && current_rank < old_rank ) {
$(this).val(current_rank + 1);
}
} else {
if ( current_rank > old_rank && current_rank <= new_rank ) {
$(this).val(current_rank - 1);
}
}
});
prev_rank_request = new_rank;
});
$(".clear-date").on("click",function(e){