Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings

This patch adds a new xt test (xt/use-test-no-warnings.t) to make sure
all our Perl test files will use Test::NoWarnings.

It also adds Test::NoWarnings to some files that were missing it and
that didn't need any other changes.

However we still have 7 non-trivial tests that we will consider
exception for now, until they are fixed.

Test plan:
  prove xt/use-test-no-warnings.t
should return green.
And all other tests modified by this patch (the qa script will do that
for you)

You can also test the 2 selenium tests:
1. DROP and CREATE the DB
  DROP DATABASE koha_kohadev;
  CREATE DATABASE koha_kohadev;
  restart_all
2. KOHA_TESTING=1 prove t/db_dependent/selenium/00-onboarding.t
3. Repeat 1
2. KOHA_TESTING=1 prove t/db_dependent/selenium/01-installation.t

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 63eb2e1f4a)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>

t/Koha/Plugins/HtmlScrubber.t

@@ -17,7 +17,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::NoWarnings;
 use Template;
 
 subtest 'test scrubbing using default scrubber' => sub {

t/db_dependent/AuthorisedValues.t

@@ -1,7 +1,8 @@
 #!/usr/bin/perl
 
 use Modern::Perl;
-use Test::More tests => 17;
+use Test::More tests => 18;
+use Test::NoWarnings;
 use Test::Exception;
 use Try::Tiny;
 

t/db_dependent/Koha/Acquisition/Booksellers.t

@@ -18,7 +18,8 @@
 use Modern::Perl;
 
 use utf8;
-use Test::More tests => 8;
+use Test::More tests => 9;
+use Test::NoWarnings;
 
 use t::lib::TestBuilder;
 

t/db_dependent/Koha/Auth/TwoFactorAuth.t

@@ -1,7 +1,8 @@
 #!/usr/bin/perl
 
 use Modern::Perl;
-use Test::More tests => 3;
+use Test::More tests => 4;
+use Test::NoWarnings;
 use Test::Exception;
 use Test::MockModule;
 

t/db_dependent/Koha/Authority.t

@@ -19,7 +19,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 1;
+use Test::More tests => 2;
+use Test::NoWarnings;
 
 use C4::AuthoritiesMarc;
 use Koha::Authorities;

t/db_dependent/Koha/BackgroundJob.t

@@ -19,7 +19,8 @@ use Modern::Perl;
 use utf8;
 use Encode;
 
-use Test::More tests => 6;
+use Test::More tests => 7;
+use Test::NoWarnings;
 use Test::MockModule;
 use Test::Exception;
 use Test::Warn;

t/db_dependent/Koha/Encryption.t

@@ -1,6 +1,7 @@
 use Modern::Perl;
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::NoWarnings;
 use Test::Exception;
 use t::lib::Mocks;
 use Koha::Encryption;

t/db_dependent/Koha/ILL/Request/Workflow/ConfirmAuto.t

@@ -17,7 +17,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 5;
+use Test::More tests => 6;
+use Test::NoWarnings;
 
 use Test::MockModule;
 use Test::MockObject;

t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t

@@ -17,7 +17,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::NoWarnings;
 
 use Test::MockModule;
 use Test::MockObject;

t/db_dependent/Koha/Plugins/ILL/Backends.t

@@ -16,7 +16,8 @@
 
 use Modern::Perl;
 use File::Basename;
-use Test::More tests => 4;
+use Test::More tests => 5;
+use Test::NoWarnings;
 
 use t::lib::Mocks;
 use t::lib::TestBuilder;

t/db_dependent/Koha/Plugins/Overdues.t

@@ -16,7 +16,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 8;
+use Test::More tests => 9;
+use Test::NoWarnings;
 use Test::Warn;
 
 use C4::Overdues qw(CalcFine);

t/db_dependent/Koha/Pseudonymization.t

@@ -19,7 +19,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 3;
+use Test::More tests => 4;
+use Test::NoWarnings;
 use Test::Warn;
 use Try::Tiny;
 

t/db_dependent/Koha/REST/Plugin/Auth/PublicRoutes.t

@@ -71,7 +71,8 @@ post '/public_guarantor' => sub {
     }
 };
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::NoWarnings;
 use Test::Mojo;
 
 use t::lib::Mocks;

t/db_dependent/Patron/Borrower_Discharge.t

@@ -16,7 +16,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 32;
+use Test::More tests => 33;
+use Test::NoWarnings;
 
 use Test::MockModule;
 use Test::Warn;

t/db_dependent/misc/translator/xgettext.pl.t

@@ -6,7 +6,8 @@ use File::Slurp;
 use File::Temp qw(tempdir);
 use FindBin    qw($Bin);
 use Locale::PO;
-use Test::More tests => 20;
+use Test::More tests => 21;
+use Test::NoWarnings;
 
 my $tempdir = tempdir( CLEANUP => 1 );
 

t/db_dependent/mojo/rest-auth.t

@@ -2,7 +2,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::NoWarnings;
 use Test::Mojo;
 
 use Koha::Database;

t/db_dependent/selenium/00-onboarding.t

@@ -22,7 +22,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::NoWarnings;
 
 use t::lib::Selenium;
 use C4::Context;

t/db_dependent/selenium/01-installation.t

@@ -22,7 +22,8 @@
 
 use Modern::Perl;
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::NoWarnings;
 
 use t::lib::Selenium;
 use C4::Context;

t/db_dependent/selenium/opac_ill_requests.t

@@ -16,7 +16,8 @@
 # along with Koha; if not, see <http://www.gnu.org/licenses>.
 
 use Modern::Perl;
-use Test::More tests => 1;
+use Test::More tests => 2;
+use Test::NoWarnings;
 
 use C4::Biblio qw(DelBiblio);
 

xt/use-test-no-warnings.t

@@ -0,0 +1,53 @@
+#/usr/bin/perl
+
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
+use Modern::Perl;
+use Test::More tests => 2;
+use Test::NoWarnings;
+
+use Array::Utils qw( array_minus );
+
+my @t_files = qx{git grep --files-without-match "Test::NoWarnings" 't/*.t'};
+chomp for @t_files;
+
+my @exceptions = (
+
+    # Cannot be removed
+    "t/00-testcritic.t",
+
+    # bug 40386
+    "t/Edifact.t",
+
+    # bug 40387
+    "t/db_dependent/Koha/EDI.t",
+
+    # bug 40382
+    "t/db_dependent/Koha/CoverImages.t",
+
+    # bug 40442
+    "t/db_dependent/Koha/MarcOrder.t",
+
+    # bug 40375
+    "t/db_dependent/XISBN.t",
+
+    # bug 40443
+    "t/db_dependent/cronjobs/advance_notices_digest.t",
+);
+
+@t_files = array_minus( @t_files, @exceptions );
+is( scalar(@t_files), 0, "All Perl test files should contain Test::NoWarnings" )
+    or diag( sprintf "The following test files should use Test::NoWarnings:\n\t%s", join "\n\t", @t_files );