From 2feabfa5dc7dc08cb2cb02b19370c354cb59b1db Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date: Wed, 8 Oct 2025 17:49:23 +0100
Subject: [PATCH] Bug 40866: Remove unused $message variable from circulation

The $message variable was declared in circ/circulation.pl but never
actually set, making the "No patron matched" template block unreachable.

This is a remnant from old code that was incompletely cleaned when that
functionality was changed/removed.

This patch removes the unused variable, template parameter, and the
unreachable template block.

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit de962e15cf32148d8909c5aa3892e7e8d979a981)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
---
 circ/circulation.pl                                         | 3 ---
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 5 -----
 2 files changed, 8 deletions(-)

diff --git a/circ/circulation.pl b/circ/circulation.pl
index b106cf9806..c98240ba73 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -325,8 +325,6 @@ if ($patron) {
 # STEP 3 : ISSUING
 #
 #
-my $message;
-
 if ( @$barcodes && $op eq 'cud-checkout' ) {
     my $checkout_infos;
     for my $barcode (@$barcodes) {
@@ -781,7 +779,6 @@ $template->param(
     stickyduedate             => $stickyduedate,
     duedatespec               => $duedatespec,
     restoreduedatespec        => $restoreduedatespec,
-    message                   => $message,
     totaldue                  => sprintf( '%.2f', $balance ),                         # FIXME not used in template?
     inprocess                 => $inprocess,
     $view                     => 1,
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
index 388d30d7eb..715fa6edfb 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ -788,11 +788,6 @@
         <p>Item checked out</p>
     [% END %]
 
-    [% IF ( message ) %]
-        [% INCLUDE 'patron-toolbar.inc' %]
-        <h4>No patron matched <span class="ex">[% message | html %]</span></h4>
-    [% END %]
-
     <!-- BARCODE ENTRY -->
 
     [% IF patron %]