From 2e3f9bd1ce6f7fe8e714c67b7458699e63437178 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Chlo=C3=A9=20Zermatten?= <chloe.zermatten@openfifth.co.uk>
Date: Tue, 25 Aug 2026 10:21:23 +0000
Subject: [PATCH] Bug 10190: (QA follow-up): fixes phase four

- Display new manage_circ_triggers permission (add to template)
- Ensure loading messages are informative to the user

Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc       | 3 +++
 .../vue/components/Admin/CirculationTriggers/EditActions.vue   | 2 +-
 .../js/vue/components/Admin/CirculationTriggers/EditNotice.vue | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
index 1d498a04fc..ebad368464 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
@@ -136,6 +136,9 @@
     [%- CASE 'manage_circ_rules' -%]
         <span class="sub_permission manage_circ_rules_subpermission"> Manage circulation rules </span>
         <span class="permissioncode">([% name | html %])</span>
+    [%- CASE 'manage_circ_triggers' -%]
+        <span class="sub_permission manage_circ_triggers_subpermission"> Manage overdue notice triggers </span>
+        <span class="permissioncode">([% name | html %])</span>
     [%- CASE 'manage_sysprefs' -%]
         <span class="sub_permission manage_sysprefs_subpermission"> Manage system preferences </span>
         <span class="permissioncode">([% name | html %])</span>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/EditActions.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/EditActions.vue
index cd31f1505d..c7f5011682 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/EditActions.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/EditActions.vue
@@ -137,7 +137,7 @@
         </ol>
     </fieldset>
     <div v-else-if="editMode === 'add' || editMode === 'edit'">
-        <p>{{ $__("Loading circulation rules...") }}</p>
+        <p>{{ $__("Loading current action settings...") }}</p>
     </div>
 </template>
 
diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/EditNotice.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/EditNotice.vue
index 5b09336dac..c3c4cb8bcd 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/EditNotice.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/EditNotice.vue
@@ -125,7 +125,7 @@
         </ol>
     </fieldset>
     <div v-else-if="editMode === 'add' || editMode === 'edit'">
-        <p>{{ $__("Loading circulation rules...") }}</p>
+        <p>{{ $__("Loading current notice settings...") }}</p>
     </div>
 </template>