gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 27716: Update permissions for patroncards creator 

The various subpages of the label creator tool we're under the
'catalogue' permission. There is however a 'label_creator' subpermission
of tools which is more appropriate.

Test plan
1/ Setup a user with just the 'catelogue' permission (to enable logging
into the staff interface)
2/ With the patch applied you should not be able to access the following
pages (either via navigation in the UI or by typing them into the
browser address bar directly)
  - /patroncards/add_user_search.pl
  - /patroncards/edit-batch.pl
  - /patroncards/edit-layout.pl
  - /patroncards/edit-profile.pl
  - /patroncards/edit-template.pl
  - /patroncards/home.pl
  - /patroncards/image-manage.pl
  - /patroncards/manage.pl
  - /patroncards/print.pl
3/ Signoff

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit bc5decc913)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Martin Renvoize 2021-02-19 10:12:32 +00:00 committed by Fridolin Somers
parent 7cef18919e
commit 2880d40bf0
9 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
patroncards/add_user_search.pl
View File

@ -34,7 +34,7 @@ my ( $template, $loggedinuser, $cookie, $staff_flags ) = get_template_and_user(
{ template_name => "common/patron_search.tt",
query => $input,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { tools => 'label_creator' },
}
);

2
patroncards/edit-batch.pl
View File

@ -37,7 +37,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "patroncards/edit-batch.tt",
query => $cgi,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { tools => 'label_creator' },
debug => 1,
}
);

2
patroncards/edit-layout.pl
View File

@ -36,7 +36,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "patroncards/edit-layout.tt",
query => $cgi,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { tools => 'label_creator' },
debug => 1,
}
);

2
patroncards/edit-profile.pl
View File

@ -33,7 +33,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "patroncards/edit-profile.tt",
query => $cgi,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { tools => 'label_creator' },
debug => 1,
}
);

2
patroncards/edit-template.pl
View File

@ -34,7 +34,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "patroncards/edit-template.tt",
query => $cgi,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { tools => 'label_creator' },
debug => 1,
}
);

2
patroncards/home.pl
View File

@ -31,7 +31,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "patroncards/home.tt",
query => $cgi,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { tools => 'label_creator' },
debug => 1,
}
);

2
patroncards/image-manage.pl
View File

@ -19,7 +19,7 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user({
template_name => "patroncards/image-manage.tt",
query => $cgi,
type => "intranet",
flagsrequired => {tools => 'batch_upload_patron_images'}, # FIXME: establish flag for patron card creator
flagsrequired => {tools => 'label_creator'},
debug => 0,
});

2
patroncards/manage.pl
View File

@ -37,7 +37,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "patroncards/manage.tt",
query => $cgi,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { tools => 'label_creator' },
debug => 1,
}
);

2
patroncards/print.pl
View File

@ -33,7 +33,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "patroncards/print.tt",
query => $cgi,
type => "intranet",
flagsrequired => { catalogue => 1 },
flagsrequired => { tools => 'label_creator' },
debug => 1,
}
);