Bug 39514: Only mark the affected rows as problematic
Before this patch we were setting a variable and nebver unsetting it
Now we can add the conditional directly to the row, so don't need a variable
To test:
1. Go to Acquisitions
2. Click 'Search' in the vendor search
3. Click 'Add to basket' next to 'My basket'
4. Click 'From a new (empty) record'
5. Fill out the form
- Title: enter a title
- Koha item type: choose an item type
5.1. Click 'Add item'
- Fund: choose a fund
- Uncertain price: check
6. Click 'Save'
7. Go back to Acquisitions
8. Click 'Search' in the vendor search
9. Click 'New' > 'Basket'
10. Enter a basket name
11. Click 'Save'
12. Go back to Acquistions
13. Click 'Search' in the vendor search
--> Notice the empty basket is also in bold red, even if it doesn't have uncertain prices
14. Click 'Add to basket'
--> Notice everything is in bold and some in red
15. Apply patch, reload
16. Only affected basket is in red
Signed-off-by: Samuel <sam.sowanick@corvallisoregon.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 7b1d11da74)
Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk>
Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
This commit is contained in:
parent
ab67d91f0d
commit
276d9169ea
|
|
@ -114,10 +114,7 @@
|
|||
</thead>
|
||||
<tbody>
|
||||
[% FOREACH basket IN supplier.loop_basket %]
|
||||
[% IF ( basket.uncertainprices ) %]
|
||||
[% SET tr_class="problem" %]
|
||||
[% END %]
|
||||
<tr class="[% tr_class | html %]">
|
||||
<tr [% IF ( basket.uncertainprices ) %]class="problem"[% END %]>
|
||||
<td>[% basket.basketno | html %]</td>
|
||||
<td><a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basket.basketno | uri %]">[% basket.basketname | html %]</a></td>
|
||||
<td data-order="[% basket.total_items | html %]">
|
||||
|
|
|
|||
Loading…
Reference in New Issue