gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 23077: Unit tests 

prove -v t/db_dependent/Koha/Patrons/Import.t

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 51bfa2ce28)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit feaaa75f15)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Nick Clemens 2019-06-07 12:18:55 +00:00 committed by Lucas Gass
parent 60b4ab8a92
commit 225c3ba5ed
1 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
t/db_dependent/Koha/Patrons/Import.t
View File

@ -18,7 +18,7 @@
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 155;
use Test::More tests => 156;
use Test::Warn;
# To be replaced by t::lib::Mock
@ -376,6 +376,34 @@ is($result_7->{imported}, 1, 'Got the expected 1 imported result from import pat
is($result_7->{invalid}, 1, 'Got the expected 1 invalid result from import patrons for dates tests');
is($result_7->{overwritten}, 0, 'Got the expected 0 overwritten result from import patrons for dates tests');
subtest 'test_import_without_cardnumber' => sub {
plan tests => 2;
#Remove possible existing user with a "" as cardnumber
my $blank_card = Koha::Patrons->find({ cardnumber => '' });
$blank_card->delete if $blank_card;
my $branchcode = $builder->build({ source => "Branch"})->{branchcode};
my $categorycode = $builder->build({ source => "Category"})->{categorycode};
my $csv_headers = 'surname, branchcode, categorycode';
my $res_headers = 'surname, branchcode, categorycode';
my $csv_nocard_1 = "Squarepants,$branchcode,$categorycode";
my $csv_nocard_2 = "Star,$branchcode,$categorycode";
my $filename_1 = make_csv($temp_dir, $csv_headers, $csv_nocard_1, $csv_nocard_2);
open(my $handle_1, "<", $filename_1) or die "cannot open < $filename_1: $!";
my $params_1 = { file => $handle_1, };
my $defaults = { cardnumber => "" }; #currently all the defaults come as "" if not filled
my $result = $patrons_import->import_patrons($params_1, $defaults);
warn Data::Dumper::Dumper( $result );
like($result->{feedback}->[1]->{value}, qr/^Squarepants \/ \d+/, 'First borrower imported as expected');
like($result->{feedback}->[2]->{value}, qr/^Star \/ \d+/, 'Second borrower imported as expected');
};
subtest 'test_prepare_columns' => sub {
plan tests => 16;