gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 34868: (QA follow-up) Rename new option, add comments 

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Kyle M Hall 2023-10-31 13:33:19 -04:00 committed by Tomas Cohen Arazi
parent 5788a0f262
commit 1feeead338
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
C4/SIP/ILS/Item.pm
View File

@ -264,7 +264,8 @@ sub sip_circulation_status {
my $self = shift;
my $server = shift;
my $missing_status = $server->{account}->{missing_lost_status};
# Defines what lost status means "missing" for this SIP account
my $missing_status = $server->{account}->{lost_status_for_missing};
if ( $self->{_object}->get_transfer ) {
return '10'; # in transit between libraries

2
etc/SIPconfig.xml
View File

@ -81,7 +81,7 @@
format_due_date="0"
inhouse_item_types=""
inhouse_patron_categories=""
missing_lost_status="4"
lost_status_for_missing="4" <!-- defines which Koha lost status will return the circulation status 13 ( i.e. missing ) for this account -->
blocked_item_types="VM|MU"
seen_on_item_information="mark_found"> <!-- could be "keep_lost", empty to disable -->
<!-- show_checkin_message: If enabled, successful checking responses will contain an AF screen message -->

2
t/db_dependent/SIP/Transaction.t
View File

@ -1185,7 +1185,7 @@ subtest item_circulation_status => sub {
$sip_item = C4::SIP::ILS::Item->new( $item->barcode );
$status = $sip_item->sip_circulation_status;
is( $status, '12', "Item circulation status is lost" );
$status = $sip_item->sip_circulation_status( { account => { missing_lost_status => "1" } } );
$status = $sip_item->sip_circulation_status( { account => { lost_status_for_missing => "1" } } );
is( $status, '13', "Item circulation status is missing" );
$item->itemlost(0)->store();