gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Bug 18179: Forbid list context calls for Koha::Objects->find" 

This reverts commit a1fcf1818c.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Kyle M Hall 2017-04-28 12:49:05 -04:00
parent c1d9a7dab7
commit 1f007ca2e9
2 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Koha/Objects.pm
View File

@ -78,8 +78,6 @@ my $object = Koha::Objects->find( { keypart1 => $keypart1, keypart2 => $keypart2
sub find {
my ( $self, $id ) = @_;
croak 'Cannot use "->find" in list context' if wantarray;
return unless defined($id);
my $result = $self->_resultset()->find($id);

12
t/db_dependent/Koha/Objects.t
View File

@ -19,7 +19,7 @@
use Modern::Perl;
use Test::More tests => 14;
use Test::More tests => 13;
use Test::Warn;
use Koha::Authority::Types;
@ -43,16 +43,6 @@ my @columns = Koha::Patrons->columns;
my $borrowernumber_exists = grep { /^borrowernumber$/ } @columns;
is( $borrowernumber_exists, 1, 'Koha::Objects->columns should return the table columns' );
subtest 'find' => sub {
plan tests => 2;
my $patron = $builder->build({source => 'Borrower'});
my $patron_object = Koha::Patrons->find( $patron->{borrowernumber} );
is( $patron_object->borrowernumber, $patron->{borrowernumber}, '->find should return the correct object' );
eval { my @patrons = Koha::Patrons->find( $patron->{borrowernumber} ); };
like( $@, qr|^Cannot use "->find" in list context|, "->find should not be called in list context to avoid side-effects" );
};
subtest 'update' => sub {
plan tests => 2;