From 1c62677aa0743557554cb5cd293894ff00d3c324 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 21 May 2025 14:52:21 +0000 Subject: [PATCH] Bug 39955: Report subgroup filter not cleared when changing tabs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman Signed-off-by: Emily Lamancusa Signed-off-by: Lucas Gass (cherry picked from commit 2de0265166d341e522a8a8d1e5f0f2497e765c1e) Signed-off-by: Paul Derscheid --- .../prog/en/modules/reports/guided_reports_start.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index 081cbb05bc..23c48bfe1c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -2481,7 +2481,7 @@ let table_dt = rtable.DataTable(); let col4 = table_dt.columns(4); col4.search("").visible(true); - let col5 = table_dt.columns(4); + let col5 = table_dt.columns(5); col5.search("").visible(true); var g_id = tab.find("a").data("tabname");