gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 41145: Add unit test coverage for stopping duplicated borrowerslog logging due to extended patron attributes being deleted on import 

This adds to the unit tests in t/db_dependent/Koha/Patrons/Import.t. It confirms that repeating the same patron import (with extended patron attributes) will not generate duplicated borrowersLog entries.

Test plan:
1. prove t/db_dependent/Koha/Patrons/Import.t

Sponsored-by: Auckland University of Technology
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit e027ed2dca)
Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk>
Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
This commit is contained in:
Alex Buckley 2025-11-12 00:01:03 +00:00 committed by Wainui Witika-Park
parent e4ef3b3ef0
commit 1a6af1dc21
No known key found for this signature in database
GPG Key ID: 2D0A6AB5DAF1B78D
1 changed files with 44 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
t/db_dependent/Koha/Patrons/Import.t
View File

@ -30,6 +30,7 @@ use Test::MockModule;
use Koha::Database;
use Koha::Patron::Relationships;
use Koha::DateUtils qw(dt_from_string);
use Koha::ActionLogs;
use File::Temp qw(tempfile tempdir);
my $temp_dir = tempdir( 'Koha_patrons_import_test_XXXX', CLEANUP => 1, TMPDIR => 1 );
@ -1497,7 +1498,9 @@ subtest 'patron_attributes' => sub {
}
subtest 'update existing patron' => sub {
plan tests => 19;
plan tests => 22;
t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
my $patron = $builder->build_object(
{
@ -1523,8 +1526,19 @@ subtest 'patron_attributes' => sub {
is( $result->{overwritten}, 1 );
my $action_logs = Koha::ActionLogs->search(
{
module => "MEMBERS",
action => "MODIFY",
object => $patron->borrowernumber,
}
);
is( $action_logs->count, 0, ' ' );
compare_patron_attributes( $patron->extended_attributes->unblessed, {%$attributes} );
t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
# Adding a new non-repeatable attribute
my $new_attributes = {
$normal_attribute_type->code => ['my normal attribute 2'],
@ -1544,6 +1558,35 @@ subtest 'patron_attributes' => sub {
# The normal_attribute_type has been replaced with 'my normal attribute 2'
compare_patron_attributes( $patron->extended_attributes->unblessed, { %$attributes, %$new_attributes } );
$action_logs = Koha::ActionLogs->search(
{
module => "MEMBERS",
action => "MODIFY",
object => $patron->borrowernumber,
}
);
is( $action_logs->count, 1, ' ' );
$result = $patrons_import->import_patrons(
{
file => $fh,
matchpoint => 'cardnumber',
overwrite_cardnumber => 1,
preserve_extended_attributes => 1
}
);
$action_logs = Koha::ActionLogs->search(
{
module => "MEMBERS",
action => "MODIFY",
object => $patron->borrowernumber,
}
);
is( $action_logs->count, 1, ' ' );
# UniqueIDConstraint
$patron->extended_attributes->delete; # reset
$builder->build_object(