From 18daee91ff957f3fd4d60d32f022bec807bf61d7 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Fri, 6 Jun 2025 09:44:23 +0000 Subject: [PATCH] Bug 39875: (QA follow-up): Correct historycheck ui_context This ui_context is supposed to be opac, not staff. For the purposes of these tests, this is not important, as the ui_context is only needed for the template params and this is testing if the history check stage is supposed to show or not. Reckon this was a copy paste without consequences hence missed, but the code is now semantically more correct. prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t Signed-off-by: Lucas Gass (cherry picked from commit dfd028871ae0e35c177d0598e4e398db5c5f3975) Signed-off-by: Paul Derscheid --- t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t b/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t index 0bbcf31539..604f270f0f 100755 --- a/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t +++ b/t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t @@ -112,7 +112,7 @@ subtest 'show_history_check' => sub { my $ill_request_with_no_borrowernumber = $builder->build_sample_ill_request( { borrowernumber => undef } ); my $new_opac_history_check = - Koha::ILL::Request::Workflow::HistoryCheck->new( $metadata_with_no_cardnumber, 'staff' ); + Koha::ILL::Request::Workflow::HistoryCheck->new( $metadata_with_no_cardnumber, 'opac' ); is( $new_opac_history_check->show_history_check($ill_request_with_no_borrowernumber),