gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 42702: Fix malformed cancel links on parcel.pl 

The pending orders table builds the two cancel order links with the
link text concatenated immediately after the invoice_id value. This
leaves the href attribute unclosed and makes the browser absorb the
link text and following escaped HTML into the href.

Add the missing separator after invoice_id for both cancel link builders.

Test plan:
1. Create a closed acquisition basket with a pending order.
2. Open an invoice receive page for the vendor.
3. Inspect the Cancel order link in the pending orders table.
4. Confirm the href ends after invoiceid and the link text is outside the href.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Andrii Nugged 2026-05-27 23:58:33 +03:00 committed by Lucas Gass
parent dacce7d3fc
commit 187c4fbb2c
No known key found for this signature in database
GPG Key ID: 60B447398B0D36CA
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
View File

@ -623,6 +623,7 @@
encodeURIComponent(row.biblio_id) +
"&referrer=/cgi-bin/koha/acqui/parcel.pl?invoiceid=" +
invoice_id +
'">' +
_("Cancel order") +
"</a><br/>";
}
@ -639,6 +640,7 @@
encodeURIComponent(row.biblio_id) +
"&del_biblio=1&referrer=/cgi-bin/koha/acqui/parcel.pl?invoiceid=" +
invoice_id +
'">' +
_("Cancel order and catalog record") +
"</a><br/>";
}