From 171f727734adc288477357097649f38b9dfdcdb6 Mon Sep 17 00:00:00 2001 From: Roman Dolny Date: Wed, 25 Feb 2026 19:39:13 +0000 Subject: [PATCH] Bug 41940: Remove uninitialized value warnings in circulation.pl The warnings: [WARN] Use of uninitialized value $patron_session_confirmation in split at /kohadevbox/koha/circ/circulation.pl line 493. [WARN] Use of uninitialized value $patron_for_session in numeric eq (==) at /kohadevbox/koha/circ/circulation.pl line 494. [WARN] Use of uninitialized value $session_confirmations in split at /kohadevbox/koha/circ/circulation.pl line 495. appears in the plack-intranet-error.log. Test plan: ========== 1. Use a fresh KTD, observe plack-intranet-error.log. 2. Have a barcode of existing item. 3. Find any patron and go to "Check out" tab. 4. Check out item. ==> Warnings should appear in plack-intranet-error.log 5. Apply the patch; restart_all. 6. Repeat 2-4 with another barcode. ==> No warnings in plack-intranet-error.log. Sponsored-by: Ignatianum University in Cracow Signed-off-by: David Nind Bug 41940: (follow-up) Syntax corrections Signed-off-by: Jonathan Druart Signed-off-by: Baptiste Wojtkowski Signed-off-by: Lucas Gass --- circ/circulation.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 3b147d865f..81c438bd45 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -528,10 +528,10 @@ if ( @$barcodes && $op eq 'cud-checkout' ) { $template_params->{ADDITIONAL_MATERIALS} = $materials; $template_params->{itemhomebranch} = $item->homebranch; - my $patron_session_confirmation = $query->cookie('patronSessionConfirmation') || undef; + my $patron_session_confirmation = $query->cookie('patronSessionConfirmation') || ''; my ( $patron_for_session, $session_confirmations ) = split( /:/, $patron_session_confirmation, 2 ); - my $patron_match = $borrowernumber == $patron_for_session; - my @conf_keys = split( /\|/, $session_confirmations ); + my $patron_match = $patron_for_session && ( $borrowernumber == $patron_for_session ); + my @conf_keys = $session_confirmations ? split( /\|/, $session_confirmations ) : (); if ( $patron_match && grep { $_ eq 'cancelreserve' } @conf_keys ) { $cancelreserve = 1; }