gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 26555: Make sure _messages is always initialized 

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomas Cohen Arazi 2020-09-30 09:42:18 -03:00 committed by Jonathan Druart
parent d576f887c1
commit 1557bf0100
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Koha/Object.pm
View File

@ -345,6 +345,10 @@ Returns the (probably non-fatal) messages that were recorded on the object.
sub messages {
my ( $self ) = @_;
$self->{_messages} = []
unless defined $self->{_messages};
return $self->{_messages};
}

14
t/db_dependent/Koha/Object.t
View File

@ -870,7 +870,9 @@ subtest 'set_or_blank' => sub {
subtest 'messages() and add_message() tests' => sub {
plan tests => 6;
plan tests => 7;
$schema->storage->txn_begin;
my $patron = Koha::Patron->new;
@ -886,5 +888,13 @@ subtest 'messages() and add_message() tests' => sub {
is( ref($messages[0]), 'Koha::Object::Message', 'Right type returned' );
is( ref($messages[1]), 'Koha::Object::Message', 'Right type returned' );
is( $messages[0]->message, 'message_1', 'Right message recorded' );
is( $messages[1]->message, 'message_2', 'Right message recorded' );
my $patron_id = $builder->build_object({ class => 'Koha::Patrons' })->id;
# get a patron from the DB, ->new is not called, ->messages should initialize _messages as an empty arrayref
$patron = Koha::Patrons->find( $patron_id );
isnt( $patron->messages, undef, '->messages initializes the array if required' );
is( scalar @{ $patron->messages }, 0, '->messages returns an empty arrayref' );
$schema->storage->txn_rollback;
};