gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 13006: suggestions.mailoverseeing cans be removed 

The DB field suggestions.mailoverseeing does not seem to be in used.
It cans be removed.

Actually it has never been in used.

Test plan:
git grep mailoverseeing
should not return relevant results.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests, updates kohastructure and includes a database update.
Also made some tests in the suggestions module.
This commit is contained in:
Jonathan Druart 2014-09-29 15:54:34 +02:00 committed by Tomas Cohen Arazi
parent 8d3ee81b14
commit 143e4656ff
4 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
installer/data/mysql/kohastructure.sql
View File

@ -2198,7 +2198,6 @@ CREATE TABLE `suggestions` ( -- purchase suggestions
`publicationyear` smallint(6) default 0,
`place` varchar(255) default NULL, -- publication place of the suggested item
`isbn` varchar(30) default NULL, -- isbn of the suggested item
`mailoverseeing` smallint(1) default 0,
`biblionumber` int(11) default NULL, -- foreign key linking the suggestion to the biblio table after the suggestion has been ordered
`reason` text, -- reason for accepting or rejecting the suggestion
`patronreason` text, -- reason for making the suggestion

4
installer/data/mysql/ru-RU/optional/sample_user_suggestions.sql
View File

@ -1,4 +1,4 @@
TRUNCATE suggestions;
INSERT INTO `suggestions` (`suggestionid`, `suggestedby`, `managedby`, `STATUS`, `note`, `author`, `title`, `copyrightdate`, `publishercode`, `date`, `volumedesc`, `publicationyear`, `place`, `isbn`, `mailoverseeing`, `biblionumber`, `reason`)
VALUES (1,0,NULL,'ASKED','нужна для УКЕ','','Мифы нашего времени',2008,'Часы','2008-05-01 08:02:26',NULL,NULL,NULL,NULL,0,0,NULL);
INSERT INTO `suggestions` (`suggestionid`, `suggestedby`, `managedby`, `STATUS`, `note`, `author`, `title`, `copyrightdate`, `publishercode`, `date`, `volumedesc`, `publicationyear`, `place`, `isbn`, `biblionumber`, `reason`)
VALUES (1,0,NULL,'ASKED','нужна для УКЕ','','Мифы нашего времени',2008,'Часы','2008-05-01 08:02:26',NULL,NULL,NULL,NULL,0,NULL);

4
installer/data/mysql/uk-UA/optional/sample_user_suggestions.sql
View File

@ -1,4 +1,4 @@
TRUNCATE suggestions;
INSERT INTO `suggestions` (`suggestionid`, `suggestedby`, `managedby`, `STATUS`, `note`, `author`, `title`, `copyrightdate`, `publishercode`, `date`, `volumedesc`, `publicationyear`, `place`, `isbn`, `mailoverseeing`, `biblionumber`, `reason`)
VALUES (1,0,NULL,'ASKED','потрібна для УКЕ','','Міфи нашого часу',2008,'Час','2008-05-01 08:02:26',NULL,NULL,NULL,NULL,0,0,NULL);
INSERT INTO `suggestions` (`suggestionid`, `suggestedby`, `managedby`, `STATUS`, `note`, `author`, `title`, `copyrightdate`, `publishercode`, `date`, `volumedesc`, `publicationyear`, `place`, `isbn`, `biblionumber`, `reason`)
VALUES (1,0,NULL,'ASKED','потрібна для УКЕ','','Міфи нашого часу',2008,'Час','2008-05-01 08:02:26',NULL,NULL,NULL,NULL,0,NULL);

9
installer/data/mysql/updatedatabase.pl
View File

@ -10000,6 +10000,15 @@ if ( CheckVersion($DBversion) ) {
SetVersion ($DBversion);
}
$DBversion = '3.19.00.XXX';
if ( CheckVersion($DBversion) ) {
$dbh->do(q{
ALTER TABLE suggestions DROP COLUMN mailoverseeing;
});
print "Upgrade to $DBversion done (Bug 13006: Drop column suggestion.mailoverseeing)";
SetVersion($DBversion);
}
# DEVELOPER PROCESS, search for anything to execute in the db_update directory
# SEE bug 13068
# if there is anything in the atomicupdate, read and execute it.