gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40046: (bug 39606 follow-up) Remove waits and screenshots 

From bug 39606:
"""
Why are you taking screenshots?
The wait statements will certainly cause random failures.

cy.wait(5000);
cy.wait(2000);

Notice the following couple of lines:
  cy.get("#fileuploadstatus").contains("100%");
  cy.get("legend").contains("Look for existing records in catalog?").should('be.visible');

It makes Cypress wait 10s until "100%" appears (ie. the file is updated), then the block with the dropdown lists you are going to interact with to be visible.

You should almost never use cy.wait.
"""

Test plan:
  yarn cypress run --spec t/cypress/integration/Tools/ManageMarcImport_spec.ts
should still pass

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit f12bbbf010)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Jonathan Druart 2025-04-23 11:15:33 +02:00 committed by Paul Derscheid
parent ad7a9355a3
commit 1406d3b7a7
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
t/cypress/integration/Tools/ManageMarcImport_spec.ts
View File

@ -34,23 +34,22 @@ describe("loads the manage MARC import page", () => {
cy.get('button[id="fileuploadbutton"]').click();
});
//wait after file upload, it can go to quickly here
cy.wait(2000);
cy.get("#fileuploadstatus").contains("100%");
cy.get("legend")
.contains("Look for existing records in catalog?")
.should("be.visible");
//check default values
cy.get('select[name="matcher"] option:selected').should(
"have.value",
""
);
cy.get('select[name="overlay_action"] option:selected').should(
cy.get("select#matcher option:selected").should("have.value", "");
cy.get("select#overlay_action option:selected").should(
"have.value",
"replace"
);
cy.get('select[name="nomatch_action"] option:selected').should(
cy.get("select#nomatch_action option:selected").should(
"have.value",
"create_new"
);
cy.get('select[name="item_action"] option:selected').should(
cy.get("select#item_action option:selected").should(
"have.value",
"always_add"
);
@ -64,28 +63,18 @@ describe("loads the manage MARC import page", () => {
cy.get("#nomatch_action").select("ignore", { force: true });
cy.get("#item_action").select("ignore", { force: true });
//remove focus
//cy.get('#item_action').blur();
cy.screenshot("after_selection");
// Now verify all values
cy.get("#matcher").should("have.value", "3");
cy.get("#overlay_action").should("have.value", "create_new");
cy.get("#nomatch_action").should("have.value", "ignore");
cy.get("#item_action").should("have.value", "ignore");
cy.screenshot("right_before_submission");
cy.get("#mainformsubmit").click();
cy.get("#job_callback").should("exist");
//wait for View batch link to load with the batch ID
cy.wait(5000);
cy.screenshot("after_waiting");
cy.contains("View batch").click();
cy.wait(2000);
// Now verify all values are retained
cy.get("#new_matcher_id").should("have.value", "3");
cy.get("#overlay_action").should("have.value", "create_new");