From 0fc8efac473af19e6eb41f7dda7cf4ebd1e22b43 Mon Sep 17 00:00:00 2001
From: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Date: Fri, 9 Jan 2026 17:44:13 +0000
Subject: [PATCH] Bug 41588: Normalize spaces in 856$u links
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

To test:
1 - add 856$u " www.cheese.com" to a record
2 - confirm link does not work from results or details in either staff interface or OPAC
3 - add 856$u "www.cheese.com " to a record
4 - confirm link does not work from results or details in either staff interface or OPAC
7 - apply patch, restart_all
8 - reload pages, confirm both links work in results and details in staff interface and OPAC

Optional final step: have some cheese as a treat

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit c58989fc51bf41fc92fd568875f304c03aa075f6)
Signed-off-by: Chloé Zermatten <chloe.zermatten@openfifth.co.uk>
---
 .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl    | 2 +-
 .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl   | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +-
 .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl      | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
index 24c7298412..076aa9edd1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
@@ -973,7 +973,7 @@
                         <xsl:with-param name="indicator1" select="@ind1"/>
                         <xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/>
                     </xsl:call-template>
-                    <xsl:value-of select="marc:subfield[@code='u']"/>
+                    <xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/>
                 </xsl:attribute>
                 <xsl:choose>
                     <xsl:when test="($Show856uAsImage='Details' or $Show856uAsImage='Both') and (substring($SubqText,1,6)='image/' or $SubqText='img' or $SubqText='bmp' or $SubqText='cod' or $SubqText='gif' or $SubqText='ief' or $SubqText='jpe' or $SubqText='jpeg' or $SubqText='jpg' or $SubqText='jfif' or $SubqText='png' or $SubqText='svg' or $SubqText='tif' or $SubqText='tiff' or $SubqText='ras' or $SubqText='cmx' or $SubqText='ico' or $SubqText='pnm' or $SubqText='pbm' or $SubqText='pgm' or $SubqText='ppm' or $SubqText='rgb' or $SubqText='xbm' or $SubqText='xpm' or $SubqText='xwd')">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
index 2b4d8eb918..5e488366c5 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
@@ -990,7 +990,7 @@
                             <xsl:with-param name="indicator1" select="@ind1"/>
                             <xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/>
                         </xsl:call-template>
-                        <xsl:value-of select="marc:subfield[@code='u']"/>
+                        <xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/>
                     </xsl:attribute>
                     <xsl:choose>
                         <xsl:when test="($Show856uAsImage='Results' or $Show856uAsImage='Both') and (substring($SubqText,1,6)='image/' or $SubqText='img' or $SubqText='bmp' or $SubqText='cod' or $SubqText='gif' or $SubqText='ief' or $SubqText='jpe' or $SubqText='jpeg' or $SubqText='jpg' or $SubqText='jfif' or $SubqText='png' or $SubqText='svg' or $SubqText='tif' or $SubqText='tiff' or $SubqText='ras' or $SubqText='cmx' or $SubqText='ico' or $SubqText='pnm' or $SubqText='pbm' or $SubqText='pgm' or $SubqText='ppm' or $SubqText='rgb' or $SubqText='xbm' or $SubqText='xpm' or $SubqText='xwd')">
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
index 2d5c76607c..c4d44a4234 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
@@ -1087,7 +1087,7 @@
                                                 <xsl:with-param name="indicator1" select="@ind1"/>
                                                 <xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/>
                                             </xsl:call-template>
-                                            <xsl:value-of select="marc:subfield[@code='u']"/>
+                                            <xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/>
                                         </xsl:attribute>
                                     </xsl:otherwise>
                                 </xsl:choose>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
index 9da8f22543..b4b8c7dc2e 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
@@ -1209,7 +1209,7 @@
                             <xsl:with-param name="indicator1" select="@ind1"/>
                             <xsl:with-param name="accessMethod" select="marc:subfield[@code='2']"/>
                         </xsl:call-template>
-                        <xsl:value-of select="marc:subfield[@code='u']"/>
+                        <xsl:value-of select="normalize-space(marc:subfield[@code='u'])"/>
                     </xsl:attribute>
 				</xsl:otherwise>
 			      </xsl:choose>