From 04809de849b522d0bd396e1ffb8e8d3dd5e00ac2 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 3 Jun 2026 12:43:43 +0100 Subject: [PATCH] Bug 42764: Fix spelling errors across the codebase Correct genuine spelling errors identified by the codespell 2.4.x full scan after the KTD container OS upgrade. Changes are in comments, POD, strings, and template text across 55 files. "SAN Ouest Provence" (the French library co-operative and Koha sponsor) is preserved as a proper noun. Perl copyright lines receive an inline # codespell:ignore annotation; about.tt files (contributor attribution pages) are added to the Koha::Devel::Files codespell exception list so that future uses of "Provence" as a typo for "Province" are still caught in all other files. Notable user-visible fixes: - "submiting" -> "submitting" in authority and bibliographic merge screens - "deleteable" -> "deletable" in patron exception messages - "Acquistions" -> "Acquisitions" in reports dictionary Test plan: 1. Apply patches 2. In the staff interface, go to Cataloguing > Merge records and confirm the submit button reads "Submitting" (not "Submiting") 3. In the staff interface, go to Authorities > Merge and confirm the same correction 4. Attempt to delete a patron with outstanding issues and confirm the error message reads "deletable" (not "deleteable") 5. prove xt/author/codespell.t => All tests pass Signed-off-by: Pedro Amorim --- C4/Auth_with_shibboleth.pm | 2 +- C4/Creators/Lib.pm | 8 ++++---- C4/Reserves.pm | 2 +- C4/SocialData.pm | 2 +- C4/Utils/DataTables/VirtualShelves.pm | 2 +- Koha/ClassSortRule.pm | 2 +- Koha/ClassSource.pm | 2 +- Koha/ClassSplitRule.pm | 2 +- Koha/Devel/Files.pm | 12 +++++++++--- Koha/EDI.pm | 2 +- Koha/Edifact.pm | 2 +- Koha/Edifact/Order.pm | 2 +- Koha/Exceptions/Patron.pm | 2 +- Koha/FrameworkPlugin.pm | 2 +- Koha/Item/Templates.pm | 2 +- Koha/Objects.pm | 2 +- Koha/Patron/Restriction/Type.pm | 2 +- Koha/Patrons/Import.pm | 2 +- Koha/Schema/Result/ReportsDictionary.pm | 2 +- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +- acqui/addorderiso2709.pl | 2 +- admin/aqbudgetperiods.pl | 2 +- admin/check_parent_total.pl | 2 +- cataloguing/value_builder/EXAMPLE.pl | 2 +- installer/data/mysql/db_revs/240600014.pl | 2 +- .../prog/en/modules/authorities/merge.tt | 2 +- .../prog/en/modules/cataloguing/merge.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/browser.js | 2 +- .../prog/js/vue/composables/base-resource.js | 2 +- .../opac-tmpl/bootstrap/en/includes/calendar.inc | 2 +- labels/label-create-pdf.pl | 6 +++--- labels/label-edit-batch.pl | 2 +- members/memberentry.pl | 2 +- members/statistics.pl | 2 +- misc/cronjobs/longoverdue.pl | 2 +- misc/migration_tools/create_analytical_rel.pl | 2 +- opac/ilsdi.pl | 6 +++--- opac/opac-modrequest.pl | 4 ++-- opac/opac-search.pl | 2 +- patroncards/edit-batch.pl | 2 +- t/Koha/SearchEngine/Search.t | 12 ++++++------ t/cypress/plugins/mockData.js | 2 +- t/db_dependent/Biblio/MarcOverlayRules.t | 2 +- t/db_dependent/Circulation/CalcDateDue.t | 2 +- t/db_dependent/Heading.t | 2 +- t/db_dependent/Koha/Biblio/Metadata.t | 2 +- t/db_dependent/Koha/Checkouts.t | 2 +- t/db_dependent/Koha/ClassSources.t | 2 +- t/db_dependent/Koha/Import/Records.t | 2 +- t/db_dependent/Koha/Patron.t | 2 +- t/db_dependent/Koha/Patrons.t | 2 +- t/db_dependent/Koha/Plugins/Plugins.t | 2 +- t/db_dependent/Koha_Misc_Files.t | 2 +- t/db_dependent/Matcher.t | 12 ++++++------ t/db_dependent/UsageStats.t | 2 +- 55 files changed, 81 insertions(+), 75 deletions(-) diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm index dd58ec747e..ccfae4ae30 100644 --- a/C4/Auth_with_shibboleth.pm +++ b/C4/Auth_with_shibboleth.pm @@ -312,7 +312,7 @@ Create some metadata for your koha instance (if you're in a single instance setu =item 2. -Swap metadata with your Identidy Provider (IdP) +Swap metadata with your Identify Provider (IdP) =item 3. diff --git a/C4/Creators/Lib.pm b/C4/Creators/Lib.pm index e71d8c86be..a2bae425aa 100644 --- a/C4/Creators/Lib.pm +++ b/C4/Creators/Lib.pm @@ -272,7 +272,7 @@ ADD_LAYOUTS: This function returns an arrayref whose elements are hashes containing all profiles upon success and 1 upon failure. Errors are logged to the Apache log. Two parameters are accepted. The first limits the field(s) returned. This parameter should be string of comma separated -fields. ie. "field_1, field_2, ...field_n" The second limits the records returned based on a string containing a valud SQL 'WHERE' filter. +fields. ie. "field_1, field_2, ...field_n" The second limits the records returned based on a string containing a valid SQL 'WHERE' filter. NOTE: Do not pass in the keyword 'WHERE.' @@ -320,7 +320,7 @@ sub get_all_image_names { This function returns an arrayref whose elements are hashes containing the batch_ids of current batches along with the item count for each batch upon success and 1 upon failure. Item counts are stored under the key '_item_count' Errors are logged to the Apache log. -One parameter is accepted which limits the records returned based on a string containing a valud SQL 'WHERE' filter. +One parameter is accepted which limits the records returned based on a string containing a valid SQL 'WHERE' filter. NOTE: Do not pass in the keyword 'WHERE.' @@ -352,7 +352,7 @@ sub get_batch_summary { This function returns an arrayref whose elements are hashes containing the label_ids of current labels along with the item count for each label upon success and 1 upon failure. Item counts are stored under the key '_item_count' Errors are logged to the Apache log. -One parameter is accepted which limits the records returned based on a string containing a valud SQL 'WHERE' filter. +One parameter is accepted which limits the records returned based on a string containing a valid SQL 'WHERE' filter. NOTE: Do not pass in the keyword 'WHERE.' @@ -405,7 +405,7 @@ sub get_label_summary { This function returns an arrayref whose elements are hashes containing the label_ids of current cards along with the item count for each card upon success and 1 upon failure. Item counts are stored under the key '_item_count' Errors are logged to the Apache log. -One parameter is accepted which limits the records returned based on a string containing a valud SQL 'WHERE' filter. +One parameter is accepted which limits the records returned based on a string containing a valid SQL 'WHERE' filter. NOTE: Do not pass in the keyword 'WHERE.' diff --git a/C4/Reserves.pm b/C4/Reserves.pm index d0739a1663..cd0fbbe239 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -1,7 +1,7 @@ package C4::Reserves; # Copyright 2000-2002 Katipo Communications -# 2006 SAN Ouest Provence +# 2006 SAN Ouest Provence # codespell:ignore # 2007-2010 BibLibre Paul POULAIN # 2011 Catalyst IT # diff --git a/C4/SocialData.pm b/C4/SocialData.pm index d00a69f52a..24f45d952a 100644 --- a/C4/SocialData.pm +++ b/C4/SocialData.pm @@ -110,7 +110,7 @@ sub update_data { $i++; } } - say "$i data insered or updated"; + say "$i data inserted or updated"; } =head2 get_report diff --git a/C4/Utils/DataTables/VirtualShelves.pm b/C4/Utils/DataTables/VirtualShelves.pm index 1bbfc40d30..68fbbd97a1 100644 --- a/C4/Utils/DataTables/VirtualShelves.pm +++ b/C4/Utils/DataTables/VirtualShelves.pm @@ -16,7 +16,7 @@ sub search { my $start = $params->{start}; my $length = $params->{length}; - # If not logged in user, be carreful and set the borrowernumber to 0 + # If not logged in user, be careful and set the borrowernumber to 0 # to prevent private lists lack my $loggedinuser = C4::Context->userenv->{'number'} || 0; diff --git a/Koha/ClassSortRule.pm b/Koha/ClassSortRule.pm index 9af44701ed..2bee1c7134 100644 --- a/Koha/ClassSortRule.pm +++ b/Koha/ClassSortRule.pm @@ -23,7 +23,7 @@ use base qw(Koha::Object); =head1 NAME -Koha::ClassSortRule Koha Classfication Sorting Rule Object class +Koha::ClassSortRule Koha Classification Sorting Rule Object class =head1 API diff --git a/Koha/ClassSource.pm b/Koha/ClassSource.pm index 3e6a5e23e5..6de9e99541 100644 --- a/Koha/ClassSource.pm +++ b/Koha/ClassSource.pm @@ -26,7 +26,7 @@ my $cache = Koha::Caches->get_instance(); =head1 NAME -Koha::ClassSource - Koha Classfication Source Object class +Koha::ClassSource - Koha Classification Source Object class =head1 API diff --git a/Koha/ClassSplitRule.pm b/Koha/ClassSplitRule.pm index 1d599cec0c..b16c4cc03e 100644 --- a/Koha/ClassSplitRule.pm +++ b/Koha/ClassSplitRule.pm @@ -25,7 +25,7 @@ use base qw(Koha::Object); =head1 NAME -Koha::ClassSplitRule Koha Classfication Splitting Rule Object class +Koha::ClassSplitRule Koha Classification Splitting Rule Object class =head1 API diff --git a/Koha/Devel/Files.pm b/Koha/Devel/Files.pm index 51e81e1cbc..4ed54179fe 100644 --- a/Koha/Devel/Files.pm +++ b/Koha/Devel/Files.pm @@ -102,9 +102,15 @@ my $exceptions = { misc/cronjobs/rss ) ], - codespell => [], - core => [], - nonce => [qw(t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt)], + codespell => [ + qw( + koha-tmpl/intranet-tmpl/prog/en/modules/about.tt + t/mock_templates/intranet-tmpl/prog/en/modules/about.tt + t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt + ) + ], + core => [], + nonce => [qw(t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt)], }, yml => { core => [], diff --git a/Koha/EDI.pm b/Koha/EDI.pm index 5fa71cac67..60499cd9ef 100644 --- a/Koha/EDI.pm +++ b/Koha/EDI.pm @@ -1603,7 +1603,7 @@ Koha::EDI Returns 1 on success undef on error Most usual cause of error is a line with no or incorrect budget codes - which woild cause order creation to abort + which would cause order creation to abort If other correct lines exist these are processed and the erroneous line os logged =head2 title_level_class diff --git a/Koha/Edifact.pm b/Koha/Edifact.pm index 6935a6fe61..300724afd4 100644 --- a/Koha/Edifact.pm +++ b/Koha/Edifact.pm @@ -414,7 +414,7 @@ Edifact - Edifact message handler =head2 service_string_advice - Examines the Service String Advice returns 1 if the default separartors are in use + Examines the Service String Advice returns 1 if the default separators are in use undef otherwise =head2 segmentize diff --git a/Koha/Edifact/Order.pm b/Koha/Edifact/Order.pm index dde0c931fc..b57c74f4eb 100644 --- a/Koha/Edifact/Order.pm +++ b/Koha/Edifact/Order.pm @@ -149,7 +149,7 @@ sub interchange_header { $hdr .= $self->interchange_control_reference(); $hdr .= $separator; - # Recipents reference password not usually used in edifact + # Recipients reference password not usually used in edifact $hdr .= q{+ORDERS}; # application reference #Edifact does not usually include the following diff --git a/Koha/Exceptions/Patron.pm b/Koha/Exceptions/Patron.pm index f775e99cd1..a60f08dfe7 100644 --- a/Koha/Exceptions/Patron.pm +++ b/Koha/Exceptions/Patron.pm @@ -21,7 +21,7 @@ use Exception::Class ( }, 'Koha::Exceptions::Patron::FailedDeleteAnonymousPatron' => { isa => 'Koha::Exceptions::Patron', - description => "Deleting patron failed, AnonymousPatron is not deleteable" + description => "Deleting patron failed, AnonymousPatron is not deletable" }, 'Koha::Exceptions::Patron::FailedDeleteProtectedPatron' => { isa => 'Koha::Exceptions::Patron', diff --git a/Koha/FrameworkPlugin.pm b/Koha/FrameworkPlugin.pm index ecc9891b07..03b35f1365 100644 --- a/Koha/FrameworkPlugin.pm +++ b/Koha/FrameworkPlugin.pm @@ -56,7 +56,7 @@ Koha::FrameworkPlugin - Facilitate use of plugins in MARC/items editor This object support two code styles: - In the new style, the plugin returns a hashref with a builder and a - launcher key pointing to two anynomous subroutines. + launcher key pointing to two anonymous subroutines. - In the old style, the builder is subroutine plugin_javascript and the launcher is subroutine plugin. For each plugin the routines are redefined. diff --git a/Koha/Item/Templates.pm b/Koha/Item/Templates.pm index a706398eea..4464dda04f 100644 --- a/Koha/Item/Templates.pm +++ b/Koha/Item/Templates.pm @@ -31,7 +31,7 @@ Koha::Item::Templates - Koha Item Template Object set class =head3 get_available -Returns a hashref with keys 'owned' and 'shared' pointing to Koha::Item::Templats objects +Returns a hashref with keys 'owned' and 'shared' pointing to Koha::Item::Templates objects representing templates owned by the user or shared to the user respectivetly. =cut diff --git a/Koha/Objects.pm b/Koha/Objects.pm index 0837701f66..2860b48d77 100644 --- a/Koha/Objects.pm +++ b/Koha/Objects.pm @@ -374,7 +374,7 @@ sub empty { Koha::Objects->reset(); -resets iteration so the next call to next() will start agein +resets iteration so the next call to next() will start again with the first object in a set. =cut diff --git a/Koha/Patron/Restriction/Type.pm b/Koha/Patron/Restriction/Type.pm index 42821784b9..1b341e9489 100644 --- a/Koha/Patron/Restriction/Type.pm +++ b/Koha/Patron/Restriction/Type.pm @@ -55,7 +55,7 @@ sub delete { my $default = Koha::Patron::Restriction::Types->find( { is_default => 1 } )->code; # We can't use Koha objects here because Koha::Patron::Debarments - # is not a Koha object. So we'll do it old skool + # is not a Koha object. So we'll do it old school my $rows = C4::Context->dbh->do( "UPDATE borrower_debarments SET type = ? WHERE type = ?", undef, ( $default, $self->code ) diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm index 4a995caf4e..2d475e8c59 100644 --- a/Koha/Patrons/Import.pm +++ b/Koha/Patrons/Import.pm @@ -594,7 +594,7 @@ LINE: while ( my $borrowerline = <$handle> ) { my @csvcolumns = $self->prepare_columns({headerrow => $borrowerline, keycol => \%csvkeycol, errors => \@errors, }); -Returns an array of all column key and populates a hash of colunm key positions. +Returns an array of all column key and populates a hash of column key positions. =cut diff --git a/Koha/Schema/Result/ReportsDictionary.pm b/Koha/Schema/Result/ReportsDictionary.pm index edacbab816..1210defb1f 100644 --- a/Koha/Schema/Result/ReportsDictionary.pm +++ b/Koha/Schema/Result/ReportsDictionary.pm @@ -75,7 +75,7 @@ SQL snippet for us in reports is_nullable: 1 size: 6 -Koha module this definition is for Circulation, Catalog, Patrons, Acquistions, Accounts) +Koha module this definition is for Circulation, Catalog, Patrons, Acquisitions, Accounts) =cut diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm index db53415d8f..427b041ebe 100644 --- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm +++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm @@ -609,7 +609,7 @@ our $koha_to_index_name = { }; # Note that sears and aat map to 008/11 values here -# but don't appear in C4/Headin/MARC21 thesaurus +# but don't appear in C4/Heading/MARC21 thesaurus # because they don't have values in controlled field indicators # https://www.loc.gov/marc/authority/ad008.html our $thesaurus_to_value = { diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl index 12d0d25ed8..cc4dfde2ad 100755 --- a/acqui/addorderiso2709.pl +++ b/acqui/addorderiso2709.pl @@ -176,7 +176,7 @@ if ( $op eq "" ) { #import selected lines $template->param( 'basketno' => $cgiparams->{'basketno'} ); - # Budget_id is mandatory for adding an order, we just add a default, the user needs to modify this aftewards + # Budget_id is mandatory for adding an order, we just add a default, the user needs to modify this afterwards my $budgets = GetBudgets(); if ( scalar @$budgets == 0 ) { die "No budgets defined, can't continue"; diff --git a/admin/aqbudgetperiods.pl b/admin/aqbudgetperiods.pl index c602cef906..3e32a3d57a 100755 --- a/admin/aqbudgetperiods.pl +++ b/admin/aqbudgetperiods.pl @@ -1,7 +1,7 @@ #!/usr/bin/perl # Copyright 2008 BibLibre, BibLibre, Paul POULAIN -# SAN Ouest Provence +# SAN Ouest Provence # codespell:ignore # # This file is part of Koha. # diff --git a/admin/check_parent_total.pl b/admin/check_parent_total.pl index 1429582577..f8983b129f 100755 --- a/admin/check_parent_total.pl +++ b/admin/check_parent_total.pl @@ -91,7 +91,7 @@ else { # FIXME - we really need a better way to do this consistently # and across the board, be it bigints, Math::FixedPoint, a -# modernized version of Math::Curency that isn't tied to the system +# modernized version of Math::Currency that isn't tied to the system # locale, or something else. $total = sprintf( "%.2f", $total ); $sub_unalloc = sprintf( "%.2f", $sub_unalloc ); diff --git a/cataloguing/value_builder/EXAMPLE.pl b/cataloguing/value_builder/EXAMPLE.pl index 7e9057e875..214f91eef2 100755 --- a/cataloguing/value_builder/EXAMPLE.pl +++ b/cataloguing/value_builder/EXAMPLE.pl @@ -23,7 +23,7 @@ use C4::Auth qw( get_template_and_user ); use C4::Output qw( output_html_with_http_headers ); # Example of framework plugin new style. -# It should define and return at least one and normally two anynomous +# It should define and return at least one and normally two anonymous # subroutines in a hash ref. # REQUEST: If you copy this code to construct a new plugin, please REMOVE # all comments copied from this file. diff --git a/installer/data/mysql/db_revs/240600014.pl b/installer/data/mysql/db_revs/240600014.pl index 008085a6f7..7b6e12cba5 100755 --- a/installer/data/mysql/db_revs/240600014.pl +++ b/installer/data/mysql/db_revs/240600014.pl @@ -4,7 +4,7 @@ use Koha::Installer::Output qw(say_warning say_success say_info); return { bug_number => "33363", description => - "Split suggestions_manage into three separate permissions for creating, updating, and deleting suggetions", + "Split suggestions_manage into three separate permissions for creating, updating, and deleting suggestions", up => sub { my ($args) = @_; my ( $dbh, $out ) = @$args{qw(dbh out)}; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt index 75a09b6f7a..4cff8d13d9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt @@ -146,7 +146,7 @@ [% Asset.js("js/authorities.js") | $raw %] [% Asset.js("js/merge-record.js") | $raw %]