gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 30828: Remove useless 'type' parameter in placerequest.pl 

To test:
 1) Grep for placerequest.pl in the source code and check that
    request.tt is the only place where the type parameter is passed.

Signed-off-by: David Nind <david@davidnind.com>

JD amended patch: adjust commit title
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 54a6c73c6d)
(cherry picked from commit 88f257ba55)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
This commit is contained in:
Joonas Kylmälä 2022-05-21 19:23:32 +00:00 committed by Arthur Suzuki
parent e7ab64cd50
commit 043ccc7163
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View File

@ -450,8 +450,6 @@
<form action="placerequest.pl" method="post" name="form" id="hold-request-form">
<input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | html %]" />
<input type="hidden" name="type" value="str8" />
[% IF ( multi_hold ) %]
<input type="hidden" name="biblionumbers" id="multi_hold_bibs" value="[% biblionumbers | html %]"/>
<input type="hidden" name="multi_holds" id="multi_holds" value="1" />

3
reserve/placerequest.pl
View File

@ -43,7 +43,6 @@ my $notes = $input->param('notes');
my $branch = $input->param('pickup');
my $startdate = $input->param('reserve_date') || '';
my @rank = $input->multi_param('rank-request');
my $type = $input->param('type');
my $title = $input->param('title');
my $checkitem = $input->param('checkitem');
my $expirationdate = $input->param('expiration_date');
@ -70,7 +69,7 @@ foreach my $bibnum (@biblionumbers) {
my $found;
if ( $type eq 'str8' && $borrower ) {
if ( $borrower ) {
foreach my $biblionumber ( keys %bibinfos ) {
my $count = @bibitems;