From 036d940d5404c4b03c0b7f2f37355c6ce8d56e74 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 13 Jun 2025 15:21:12 -0300 Subject: [PATCH] Bug 39911: Remove redundant warn Following the original test plan you notice, `THIS IS A TEST` is printed twice: * In the logs. * In STDERR for the SIP server. The latter is redundant, and also problematic for `xt/author/pod_coverage.t` which fails the `no warnings` tests because of that. To test: 1. Run: $ ktd --shell k$ prove xt/author/pod_coverage.t => FAIL: Scary errors, lots of them 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Follow the original bug test plan => SUCCESS: There's `THIS IS A TEST` in the logs, which was the author's goal in the first place. 5. Sign off :-D 6. Visit bug 40144 :-P Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass (cherry picked from commit 9a4fd4facb81f75aa47e5412e9e1bf5269a24672) Signed-off-by: Paul Derscheid --- C4/SIP/Trapper.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/C4/SIP/Trapper.pm b/C4/SIP/Trapper.pm index a9e87e3907..5254fba043 100644 --- a/C4/SIP/Trapper.pm +++ b/C4/SIP/Trapper.pm @@ -68,7 +68,6 @@ $SIG{__DIE__} = sub { my $msg = shift; my $logger = Koha::Logger->get( { interface => 'sip', category => 'STDERR' } ); $logger->error($msg) if $logger; - warn $msg; # die doesn't output the message, warn before dying die $msg; };